classification
Title: 2to3 doesn't work when run from a zipfile
Type: Stage: resolved
Components: 2to3 (2.x to 3.x conversion tool) Versions: Python 3.9, Python 3.8, Python 3.7, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: benjamin.peterson Nosy List: benjamin.peterson, miss-islington
Priority: normal Keywords: patch

Created on 2019-07-24 23:15 by benjamin.peterson, last changed 2019-07-25 00:00 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14942 merged benjamin.peterson, 2019-07-24 23:18
PR 14943 merged miss-islington, 2019-07-24 23:39
PR 14944 merged miss-islington, 2019-07-24 23:39
PR 14945 merged miss-islington, 2019-07-24 23:39
Messages (5)
msg348413 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2019-07-24 23:15
get_all_fix_names does listdir() to find fixers. That breaks if the standard library is in a zipfile. It shouldn't be hard to replace this with pkgutil.iter_modules.
msg348416 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2019-07-24 23:38
New changeset 93e8aa62cfd0a61efed4a61a2ffc2283ae986ef2 by Benjamin Peterson in branch 'master':
closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942)
https://github.com/python/cpython/commit/93e8aa62cfd0a61efed4a61a2ffc2283ae986ef2
msg348418 - (view) Author: miss-islington (miss-islington) Date: 2019-07-24 23:57
New changeset 9194a20a5b0b933a2a43ce0e81becbf8f0356314 by Miss Islington (bot) in branch '3.7':
closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942)
https://github.com/python/cpython/commit/9194a20a5b0b933a2a43ce0e81becbf8f0356314
msg348419 - (view) Author: miss-islington (miss-islington) Date: 2019-07-24 23:59
New changeset 53639dd55a0d5b3b7b4ef6ae839a98008f22e2d3 by Miss Islington (bot) in branch '2.7':
closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942)
https://github.com/python/cpython/commit/53639dd55a0d5b3b7b4ef6ae839a98008f22e2d3
msg348420 - (view) Author: miss-islington (miss-islington) Date: 2019-07-25 00:00
New changeset 69802f6163c9f18ca0e0b9c4c43a49365fc63e2d by Miss Islington (bot) in branch '3.8':
closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942)
https://github.com/python/cpython/commit/69802f6163c9f18ca0e0b9c4c43a49365fc63e2d
History
Date User Action Args
2019-07-25 00:00:42miss-islingtonsetmessages: + msg348420
2019-07-24 23:59:34miss-islingtonsetmessages: + msg348419
2019-07-24 23:57:42miss-islingtonsetnosy: + miss-islington
messages: + msg348418
2019-07-24 23:39:40miss-islingtonsetpull_requests: + pull_request14717
2019-07-24 23:39:16miss-islingtonsetpull_requests: + pull_request14716
2019-07-24 23:39:07miss-islingtonsetpull_requests: + pull_request14715
2019-07-24 23:38:53benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg348416

stage: patch review -> resolved
2019-07-24 23:18:55benjamin.petersonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request14714
2019-07-24 23:15:13benjamin.petersoncreate