➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008-09-03 22:32 by gpolo, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| str_result.diff | gpolo, 2008-09-03 22:32 | |||
| tkColorChooser.diff | gpolo, 2008-11-18 13:01 | |||
| Messages (4) | |||
|---|---|---|---|
| msg72425 - (view) | Author: Guilherme Polo (gpolo) *  |
Date: 2008-09-03 22:32 | |
Chooser._fixresult in the tkColorChooser module uses "if not result" to check if user canceled the dialog, but nowadays Tk may return a cached object that contains the result we are after, so, this object will not simply evaluate to false and _fixresult will act like if the user didn't cancel the dialog. The fix is simple, just get the real value of result in that check. |
|||
| msg76007 - (view) | Author: Guilherme Polo (gpolo) * |
Date: 2008-11-18 13:01 | |
I've noticed a problem with the previous patch, so this new one includes a comment too so people can remember about the check being applied. |
|||
| msg77745 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2008-12-13 15:10 | |
Thanks for the patch. Committed tkColorChooser.diff as r67738 in the 2.5 branch. Applying this to the other branches still needs to be done. |
|||
| msg78462 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2008-12-29 16:28 | |
Committed into various branches as r68010, r68011, r68012, and r68013 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:38 | admin | set | nosy:
+ barry, benjamin.peterson github: 48017 |
| 2008-12-29 16:28:46 | loewis | set | status: open -> closed messages: + msg78462 |
| 2008-12-20 14:36:54 | loewis | set | versions: - Python 2.5, Python 2.5.3 |
| 2008-12-20 02:41:39 | loewis | set | priority: deferred blocker -> release blocker |
| 2008-12-13 15:10:42 | loewis | set | priority: release blocker -> deferred blocker assignee: loewis messages: + msg77745 resolution: accepted nosy: + loewis |
| 2008-12-10 08:46:33 | loewis | set | priority: release blocker |
| 2008-11-18 13:01:21 | gpolo | set | files:
+ tkColorChooser.diff messages: + msg76007 versions: + Python 2.7, Python 2.5.3 |
| 2008-09-03 22:32:10 | gpolo | create | |