classification
Title: Remove redudant code in socket.py
Type: Stage: resolved
Components: Library (Lib) Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: aldwinaldwin, benjamin.peterson, shihai1991
Priority: normal Keywords: patch

Created on 2019-07-11 17:21 by shihai1991, last changed 2019-07-12 02:18 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14711 merged shihai1991, 2019-07-11 17:24
Messages (3)
msg347692 - (view) Author: hai shi (shihai1991) * Date: 2019-07-11 17:21
Looks like the _realsocket in socket.py is redudnat. But I am not sure somebody would use it or not.

REF: https://github.com/python/cpython/blob/master/Lib/socket.py#L107
msg347716 - (view) Author: Aldwin Pollefeyt (aldwinaldwin) * Date: 2019-07-12 01:53
seems it is/was used in socket._socketobject in 2.7
msg347717 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2019-07-12 02:18
New changeset c8e7146de257930ea8d0d4aa74b3a64fcaa79d4b by Benjamin Peterson (Hai Shi) in branch 'master':
closes bpo-37566: Remove _realsocket from socket.py. (GH-14711)
https://github.com/python/cpython/commit/c8e7146de257930ea8d0d4aa74b3a64fcaa79d4b
History
Date User Action Args
2019-07-12 02:18:15benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg347717

resolution: fixed
stage: patch review -> resolved
2019-07-12 01:53:50aldwinaldwinsetnosy: + aldwinaldwin
messages: + msg347716
2019-07-11 17:24:06shihai1991setkeywords: + patch
stage: patch review
pull_requests: + pull_request14511
2019-07-11 17:21:31shihai1991create