Title: Refactor zipfile to ease subclassing and enhancement
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.9
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: dhillier, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2019-07-10 06:58 by dhillier, last changed 2019-07-26 09:26 by dhillier.

Pull Requests
URL Status Linked Edit
PR 14957 open dhillier, 2019-07-26 09:26
Messages (4)
msg347604 - (view) Author: Daniel Hillier (dhillier) * Date: 2019-07-10 06:58
I've written which incorporates a
refactor of in order to support winzip AES encryption. I don't
intend to include the crypto code but I would like to incorporate the
refactor to help others subclass and extend the objects found in

For a longer description of the general approach I've taken to the refactor,
see the python-ideas thread:
msg347609 - (view) Author: Daniel Hillier (dhillier) * Date: 2019-07-10 08:15
I've started a branch on my github fork if anyone wants to follow along.

Is there a better way to manage this in terms of review and suggestions as I add more commits?
msg347613 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-07-10 10:43
I did not read your code yet, but I think it is the right way.

If your btanch contains changes which you do not want to commit to CPython, but which makes the purpose of other changes clearer, you can create a PR against the master in your fork
msg347972 - (view) Author: Daniel Hillier (dhillier) * Date: 2019-07-15 15:15

Here is a pull request against my fork:

The overall behaviour of zipfile remains the same and I've tried to call out any behaviour changes in the extended commit messages (usually with ** markers).

There is another branch ( which has a couple of extra commits which slightly changes some functionality.

Any review would be greatly appreciated! Happy to make any changes to the code or general approach taken.

Date User Action Args
2019-07-26 09:26:37dhilliersetkeywords: + patch
stage: patch review
pull_requests: + pull_request14725
2019-07-15 15:15:28dhilliersetmessages: + msg347972
2019-07-10 10:43:19serhiy.storchakasetmessages: + msg347613
2019-07-10 08:15:39dhilliersetmessages: + msg347609
2019-07-10 07:15:27serhiy.storchakasetnosy: + serhiy.storchaka
2019-07-10 06:58:30dhilliercreate