This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Make it explicit that logging QueueHandler / QueueListener accepts a SimpleQueue.
Type: Stage: resolved
Components: Documentation Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, mjpieters, vinay.sajip
Priority: normal Keywords: patch

Created on 2019-07-01 13:41 by mjpieters, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14521 merged vinay.sajip, 2019-07-01 16:52
PR 14525 merged miss-islington, 2019-07-01 17:45
PR 14526 merged miss-islington, 2019-07-01 17:45
Messages (4)
msg347017 - (view) Author: Martijn Pieters (mjpieters) * Date: 2019-07-01 13:41
The implementation of the logging.handler.QueueHandler and logging.handler.QueueListener does not make use of the task tracking API of queues (queue.task_done(), queue.join()) nor does it care if the queue is unbounded (queue.full(), catching the Full exception).

As such, it can work just as well with the new queue.SimpleQueue implementation (new in 3.7, see https://docs.python.org/3/library/queue.html#queue.SimpleQueue), which is fast and lightweight, implemented in C.

Can the documentation be updated to make this option explicit?
msg347052 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2019-07-01 17:45
New changeset e6b64b756f940147728ea7808fb686ffcae89176 by Vinay Sajip in branch 'master':
bpo-37469: Document usability of SimpleQueue with QueueHandler and QueueListener. (GH-14521)
https://github.com/python/cpython/commit/e6b64b756f940147728ea7808fb686ffcae89176
msg347062 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2019-07-01 18:53
New changeset b0ab95bbe792b38e952688f8fa1657a78b35410e by Vinay Sajip (Miss Islington (bot)) in branch '3.7':
bpo-37469: Document usability of SimpleQueue with QueueHandler and QueueListener. (GH-14521) (GH-14526)
https://github.com/python/cpython/commit/b0ab95bbe792b38e952688f8fa1657a78b35410e
msg347063 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2019-07-01 18:53
New changeset 6cde61369e8174c493ca240cb52ebc9c2a2fe667 by Vinay Sajip (Miss Islington (bot)) in branch '3.8':
bpo-37469: Document usability of SimpleQueue with QueueHandler and QueueListener. (GH-14521) (GH-14525)
https://github.com/python/cpython/commit/6cde61369e8174c493ca240cb52ebc9c2a2fe667
History
Date User Action Args
2022-04-11 14:59:17adminsetgithub: 81650
2019-07-01 18:54:32vinay.sajipsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-07-01 18:53:31vinay.sajipsetmessages: + msg347063
2019-07-01 18:53:01vinay.sajipsetmessages: + msg347062
2019-07-01 17:45:39miss-islingtonsetpull_requests: + pull_request14339
2019-07-01 17:45:32miss-islingtonsetpull_requests: + pull_request14338
2019-07-01 17:45:10vinay.sajipsetmessages: + msg347052
2019-07-01 16:52:17vinay.sajipsetkeywords: + patch
stage: patch review
pull_requests: + pull_request14335
2019-07-01 13:48:21xtreaksetnosy: + vinay.sajip
2019-07-01 13:41:45mjpieterscreate