➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fail build on windows 10(visual studio 2019)
Type: compile error Stage: resolved
Components: Build, Windows Versions: Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: heckad, miss-islington, paul.moore, steve.dower, tim.golden, xtreak, zach.ware
Priority: normal Keywords: patch

Created on 2019-06-19 02:52 by heckad, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14240 merged steve.dower, 2019-06-19 17:56
PR 14243 merged miss-islington, 2019-06-19 20:07
Messages (5)
msg346019 - (view) Author: Андрей Казанцев (heckad) * Date: 2019-06-19 02:52 
Error	MSB4113	Specified condition "$(IncludeTkinter)" evaluates to "" instead of a boolean.	python	cpython\PCbuild\python.vcxproj	156

It is the master branch (id: 0a28f8d379544eee897979da0ce99f0b449b49dd)
msg346024 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2019-06-19 07:43 
Probably related issue where the flag was added to python.vcxproj : issue37288
msg346079 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-06-19 20:07 
New changeset 12f1c726d8328e5e096c35c36901f6d19bc942d3 by Steve Dower in branch 'master':
bpo-37333: Ensure IncludeTkinter has a value (GH-14240)
https://github.com/python/cpython/commit/12f1c726d8328e5e096c35c36901f6d19bc942d3
msg346080 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-06-19 20:09 
Backport will automerge when it's done.
msg346082 - (view) Author: miss-islington (miss-islington) Date: 2019-06-19 20:26 
New changeset 389abd37ba50a327ae7388c6b016604cbd980e4b by Miss Islington (bot) in branch '3.8':
bpo-37333: Ensure IncludeTkinter has a value (GH-14240)
https://github.com/python/cpython/commit/389abd37ba50a327ae7388c6b016604cbd980e4b
History
Date User Action Args
2022-04-11 14:59:16adminsetgithub: 81514
2019-06-19 20:26:10miss-islingtonsetnosy: + miss-islington
messages: + msg346082
2019-06-19 20:09:05steve.dowersetstatus: open -> closed
resolution: fixed
messages: + msg346080

stage: patch review -> resolved
2019-06-19 20:07:53miss-islingtonsetpull_requests: + pull_request14078
2019-06-19 20:07:50steve.dowersetmessages: + msg346079
2019-06-19 17:56:10steve.dowersetkeywords: + patch
stage: patch review
pull_requests: + pull_request14075
2019-06-19 17:55:53steve.dowersetassignee: steve.dower
type: compile error
versions: + Python 3.8
2019-06-19 07:43:59xtreaksetnosy: + paul.moore, tim.golden, xtreak, zach.ware, steve.dower
messages: + msg346024
components: + Windows
2019-06-19 02:52:17heckadcreate