classification
Title: test_gdb's test_pycfunction should test all calling conventions
Type: Stage: resolved
Components: Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: petr.viktorin Nosy List: petr.viktorin
Priority: normal Keywords: patch

Created on 2019-05-29 21:38 by petr.viktorin, last changed 2019-09-12 14:38 by petr.viktorin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 13668 merged petr.viktorin, 2019-05-29 21:46
Messages (2)
msg343927 - (view) Author: Petr Viktorin (petr.viktorin) * (Python committer) Date: 2019-05-29 21:38
test_gdb.StackNavigationTests.test_pycfunction checks that the GDB integration can pick up calls to C-API functions. Currently it includes the comment:

> Tested function must not be defined with METH_NOARGS or METH_O,
> otherwise call_function() doesn't call PyCFunction_Call()

This is (now?) false; furthermore it looks like all builtin_function_or_method are discoverable.

As the code paths for various METH_* conventions are diverging due to optimizations, we should check they continue to be covered.
msg352181 - (view) Author: Petr Viktorin (petr.viktorin) * (Python committer) Date: 2019-09-12 14:38
Fixed here and in https://bugs.python.org/issue37499 ( https://github.com/python/cpython/pull/15776 )
History
Date User Action Args
2019-09-12 14:38:12petr.viktorinsetstatus: open -> closed
resolution: fixed
messages: + msg352181

stage: patch review -> resolved
2019-05-29 21:46:42petr.viktorinsetkeywords: + patch
stage: patch review
pull_requests: + pull_request13557
2019-05-29 21:38:35petr.viktorincreate