Created on 2019-05-24 21:56 by terry.reedy, last changed 2019-06-11 05:54 by terry.reedy. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 13560 | merged | terry.reedy, 2019-05-24 23:03 | |
| PR 13561 | merged | miss-islington, 2019-05-25 02:18 | |
| Messages (5) | |||
|---|---|---|---|
| msg343433 - (view) | Author: Terry J. Reedy (terry.reedy) *  |
Date: 2019-05-24 21:56 | |
Slightly simplified, pyshell.ModifiedInterpreter.built_subprocess runs
f'{sys.executable} -c "__import__('idlelib.run').run.main()"'.
"__import__('idlelib.run')" creates sys.modules['idlelib'] from idlelib/__init__.py, creates sys.modules['idlelib.run'] from idlelib/run.py, binds 'run' to the idlelib.run module in the idlelib module, and returns the idlelib module. It does not bind any names in the main module of the new process. '.run' gets the idlelib.run module and '.main()' executes its main function. This eventually executes user code in the so-far untouched main module.
During the creation of the idlelib.run module, various other idlelib module are imported. Some of these import both tkinter and its submodules, such as tkinter.font, adding names such as 'font' to the tkinter modules. To prevent user code running when it should not, these added names are deleted. #25507.
Once the deletion code is run, it will fail with AttributeError if run again, such as from an IDLE editor. The patch solves this by adding a flag that indicates that the file has already be imported into the process.
|
|||
| msg343449 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2019-05-25 01:59 | |
New changeset 81bb97df6138c755e229dcdac9bed747e31b61b3 by Terry Jan Reedy in branch 'master': bpo-37038: Make idlelib.run runnable; add test clause (GH-13560) https://github.com/python/cpython/commit/81bb97df6138c755e229dcdac9bed747e31b61b3 |
|||
| msg343453 - (view) | Author: miss-islington (miss-islington) | Date: 2019-05-25 05:10 | |
New changeset c70ab1cca0f43dbf3bad4acacd06a792cdbe03c8 by Miss Islington (bot) in branch '3.7': bpo-37038: Make idlelib.run runnable; add test clause (GH-13560) https://github.com/python/cpython/commit/c70ab1cca0f43dbf3bad4acacd06a792cdbe03c8 |
|||
| msg345184 - (view) | Author: Tal Einat (taleinat) * |
Date: 2019-06-11 05:49 | |
Terry, I believe this can be closed now that the fix has been merged? |
|||
| msg345188 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2019-06-11 05:54 | |
Yes, thank you. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-06-11 05:54:03 | terry.reedy | set | status: open -> closed resolution: fixed messages: + msg345188 stage: patch review -> resolved |
| 2019-06-11 05:49:44 | taleinat | set | nosy:
+ taleinat messages: + msg345184 |
| 2019-05-25 05:10:13 | miss-islington | set | nosy:
+ miss-islington messages: + msg343453 |
| 2019-05-25 02:18:32 | miss-islington | set | pull_requests: + pull_request13472 |
| 2019-05-25 01:59:57 | terry.reedy | set | messages: + msg343449 |
| 2019-05-24 23:03:11 | terry.reedy | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request13471 |
| 2019-05-24 21:56:19 | terry.reedy | create | |