This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Can _random.getrandbits() be converted to METH_FASTCALL?
Type: performance Stage: resolved
Components: Extension Modules Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: pablogsal, rhettinger, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2019-05-23 15:16 by rhettinger, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 13532 merged pablogsal, 2019-05-23 23:04
Messages (4)
msg343308 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-05-23 16:29
Sure. The simlest way is to use Argument Clinic.
msg343310 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-05-23 16:45
If you hate Argument Clinic you can use METH_O and _PyLong_AsInt().
msg343428 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2019-05-24 21:09
New changeset 561612d8456cfab5672c9b445521113b847bd6b3 by Pablo Galindo in branch 'master':
bpo-37021: Port _randommodule to the argument clinic (GH-13532)
https://github.com/python/cpython/commit/561612d8456cfab5672c9b445521113b847bd6b3
msg343557 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2019-05-26 16:28
This looks good.  Thanks.
History
Date User Action Args
2022-04-11 14:59:15adminsetgithub: 81202
2019-05-26 16:28:29rhettingersetmessages: + msg343557
2019-05-24 21:09:43pablogsalsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-05-24 21:09:26pablogsalsetnosy: + pablogsal
messages: + msg343428
2019-05-23 23:04:47pablogsalsetkeywords: + patch
stage: patch review
pull_requests: + pull_request13447
2019-05-23 16:45:19serhiy.storchakasetmessages: + msg343310
2019-05-23 16:29:38serhiy.storchakasetmessages: + msg343308
2019-05-23 15:16:57rhettingercreate