Created on 2019-05-08 15:40 by pablogsal, last changed 2019-05-13 15:31 by vstinner. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 13191 | merged | pablogsal, 2019-05-08 15:43 | |
| Messages (3) | |||
|---|---|---|---|
| msg341891 - (view) | Author: Pablo Galindo Salgado (pablogsal) *  |
Date: 2019-05-08 15:40 | |
When evaluating a frame object, it is possible to exit the execution with some variables in the stack. The frame deallocator (frame_dealloc) only cleans the stack if f_stacktop is not NULL, but this only happens for generators and when trace functions are set. The eval loop does this cleanup already if an exception is being raised, but not if a RETURN_VALUE is set. In the PyconUS sprints, Dino and I have been working on this and we have decided that the cleanest approach is shared the same goto label with the path for exception handling, effectively cleaning up |
|||
| msg341986 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2019-05-09 15:52 | |
New changeset f00828a742d2e88c910bdfd00f08fcd998554ba5 by Pablo Galindo in branch 'master': bpo-36851: Clean the frame stack if the execution ends with a return and the stack is not empty (GH-13191) https://github.com/python/cpython/commit/f00828a742d2e88c910bdfd00f08fcd998554ba5 |
|||
| msg342341 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-05-13 15:31 | |
I marked bpo-36725 as a duplicate of this issue. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-05-13 15:31:20 | vstinner | set | nosy:
+ vstinner messages: + msg342341 |
| 2019-05-13 15:31:06 | vstinner | link | issue36725 superseder |
| 2019-05-09 15:52:19 | pablogsal | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-05-09 15:52:06 | pablogsal | set | messages: + msg341986 |
| 2019-05-08 15:43:09 | pablogsal | set | keywords:
+ patch stage: patch review pull_requests: + pull_request13103 |
| 2019-05-08 15:40:55 | pablogsal | create | |