Created on 2019-04-29 06:12 by inada.naoki, last changed 2019-05-16 19:34 by mangrisano. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| bm_textio.py | inada.naoki, 2019-04-29 06:12 | |||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 13002 | merged | inada.naoki, 2019-04-29 06:18 | |
| PR 13359 | mangrisano, 2019-05-16 19:34 | ||
| Messages (2) | |||
|---|---|---|---|
| msg341044 - (view) | Author: Inada Naoki (inada.naoki) *  |
Date: 2019-04-29 06:12 | |
textio uses list of textio for internal buffering. There are two inefficiency: * When textio is line buffered and all written strings are line (it's very common), list object is allocated and freed. * We convert texts into bytes, and call b''.join(list_of_bytes). But when texts are ASCII and codecs are ASCII-compat, we can skip temporary bytes objects. Attached patch is benchmark for buffered and line buffered write. Faster (6): - write_ascii_32k: 101 ns +- 1 ns -> 73.1 ns +- 0.4 ns: 1.39x faster (-28%) - write_ascii_8k: 102 ns +- 1 ns -> 73.4 ns +- 0.4 ns: 1.38x faster (-28%) - write_ascii_linebuffered: 815 ns +- 12 ns -> 731 ns +- 3 ns: 1.12x faster (-10%) - write_unicode_linebuffered: 840 ns +- 11 ns -> 789 ns +- 15 ns: 1.06x faster (-6%) - write_unicode_8k: 124 ns +- 1 ns -> 122 ns +- 1 ns: 1.01x faster (-1%) - write_unicode_32k: 124 ns +- 1 ns -> 122 ns +- 1 ns: 1.01x faster (-1%) |
|||
| msg342627 - (view) | Author: Inada Naoki (inada.naoki) * |
Date: 2019-05-16 06:03 | |
New changeset bfba8c373e362d48d4ee0e0cf55b8d9c169344ae by Inada Naoki in branch 'master': bpo-36748: optimize TextIOWrapper.write() for ASCII string (GH-13002) https://github.com/python/cpython/commit/bfba8c373e362d48d4ee0e0cf55b8d9c169344ae |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-05-16 19:34:02 | mangrisano | set | pull_requests: + pull_request13274 |
| 2019-05-16 06:20:43 | inada.naoki | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-05-16 06:03:27 | inada.naoki | set | messages: + msg342627 |
| 2019-04-29 06:18:42 | inada.naoki | set | keywords:
+ patch stage: patch review pull_requests: + pull_request12923 |
| 2019-04-29 06:12:38 | inada.naoki | create | |