classification
Title: Modules/faulthandler.c does not compile on HP-UX due to bpo-35214/1584a0081500d35dc93ff88e5836df35faf3e3e2
Type: compile error Stage: resolved
Components: Build Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gregory.p.smith, michael-o, miss-islington, vstinner
Priority: normal Keywords: patch

Created on 2019-04-26 11:29 by michael-o, last changed 2019-04-30 22:00 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12970 merged vstinner, 2019-04-26 15:14
PR 13027 merged miss-islington, 2019-04-30 21:11
Messages (8)
msg340913 - (view) Author: Michael Osipov (michael-o) * Date: 2019-04-26 11:29
> /opt/aCC/bin/aCC -Ae  -O      -I./Include/internal  -I. -I./Include -I/opt/ports/include -I/opt/ports/include  -DPy_BUILD_CORE_BUILTIN  -c ./Modules/faulthandler.c -o Modules/faulthandler.o
> "./Modules/faulthandler.c", line 1373: error #2029: expected an expression
>           stack_t current_stack = {};

The fix is trivial:
> stack_t current_stack = {0};

Can also provide a PR for that.
msg340922 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-04-26 15:15
Michael Osipov: Can you please try if attached PR 12970 fix the compilation on HP-UX?
msg341142 - (view) Author: Michael Osipov (michael-o) * Date: 2019-04-30 10:10
The memset() works as expected and compiles for me.
msg341143 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-04-30 10:19
New changeset b84cb70880a0acfcbbaca7bcda405af08f94d269 by Victor Stinner in branch 'master':
bpo-36734: Fix compilation of faulthandler.c on HP-UX (GH-12970)
https://github.com/python/cpython/commit/b84cb70880a0acfcbbaca7bcda405af08f94d269
msg341144 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-04-30 10:20
Thanks for testing, I merged my PR. Does Python 3.7 have the same issue?
msg341147 - (view) Author: Michael Osipov (michael-o) * Date: 2019-04-30 10:52
I do not know because I haven't really tested that branch. My HP-UX PRs (https://github.com/python/cpython/pulls/michael-o) are still open and apply to master currently. We (you and me) agreed some time ago, that we go master first.
msg341164 - (view) Author: miss-islington (miss-islington) Date: 2019-04-30 21:30
New changeset 5f5b187bfa17254f5ae55593820fc938c45c2b32 by Miss Islington (bot) in branch '3.7':
bpo-36734: Fix compilation of faulthandler.c on HP-UX (GH-12970)
https://github.com/python/cpython/commit/5f5b187bfa17254f5ae55593820fc938c45c2b32
msg341165 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-04-30 22:00
Python 3.7 was also affected: I fixed it as well. Thanks for your bug report.
History
Date User Action Args
2019-04-30 22:00:06vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg341165

stage: patch review -> resolved
2019-04-30 21:30:47miss-islingtonsetnosy: + miss-islington
messages: + msg341164
2019-04-30 21:11:47miss-islingtonsetpull_requests: + pull_request12949
2019-04-30 10:52:19michael-osetmessages: + msg341147
2019-04-30 10:20:30vstinnersetmessages: + msg341144
2019-04-30 10:19:55vstinnersetmessages: + msg341143
2019-04-30 10:10:00michael-osetmessages: + msg341142
2019-04-26 15:15:14vstinnersetmessages: + msg340922
2019-04-26 15:14:46vstinnersetkeywords: + patch
stage: patch review
pull_requests: + pull_request12897
2019-04-26 11:39:09SilentGhostsetnosy: + vstinner
2019-04-26 11:29:08michael-ocreate