➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: duplicate method definition in Lib/test/test_genericclass.py
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: levkivskyi, steve.dower, xdegaye
Priority: normal Keywords: patch

Created on 2019-04-20 15:59 by xdegaye, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12892 merged Windson Yang, 2019-04-21 00:59
PR 12978 merged levkivskyi, 2019-04-27 01:02
Messages (6)
msg340579 - (view) Author: Xavier de Gaye (xdegaye) * (Python triager) Date: 2019-04-20 15:59 
As reported in issue 16079, the following method is a duplicate:

Lib/test/test_genericclass.py:161 TestClassGetitem.test_class_getitem
msg340674 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-04-22 18:51 
New changeset d437012cdd4a38b5b3d05f139d5f0a28196e4769 by Steve Dower (Windson yang) in branch 'master':
bpo-36679: Rename duplicate test_class_getitem function (GH-12892)
https://github.com/python/cpython/commit/d437012cdd4a38b5b3d05f139d5f0a28196e4769
msg340938 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2019-04-26 20:12 
Thanks for fixing this!
msg340939 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2019-04-26 20:13 
Oh, sorry, didn't notice the backport is missing!
msg340955 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2019-04-27 01:21 
New changeset d111490a1f63db2dcc3714157726dc6a5c0fa1cd by Ivan Levkivskyi in branch '3.7':
[3.7] bpo-36679: Rename duplicate test_class_getitem function (GH-12892) (GH-12978)
https://github.com/python/cpython/commit/d111490a1f63db2dcc3714157726dc6a5c0fa1cd
msg340956 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2019-04-27 01:23 
OK, backported the fix to 3.7.
History
Date User Action Args
2022-04-11 14:59:14adminsetgithub: 80860
2019-04-27 01:23:23levkivskyisetstatus: open -> closed

messages: + msg340956
stage: patch review -> resolved
2019-04-27 01:21:48levkivskyisetmessages: + msg340955
2019-04-27 01:02:18levkivskyisetstage: resolved -> patch review
pull_requests: + pull_request12904
2019-04-26 20:14:37levkivskyisetstatus: closed -> open
2019-04-26 20:13:15levkivskyisetmessages: + msg340939
2019-04-26 20:12:26levkivskyisetstatus: open -> closed

nosy: + levkivskyi
messages: + msg340938

resolution: fixed
stage: resolved
2019-04-25 14:55:58xdegayesetstatus: closed -> open
stage: resolved -> (no value)
resolution: fixed -> (no value)
versions: + Python 3.7
2019-04-22 18:54:45steve.dowersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-04-22 18:51:09steve.dowersetnosy: + steve.dower
messages: + msg340674
2019-04-21 00:59:53Windson Yangsetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request12816
2019-04-20 15:59:38xdegayecreate