classification
Title: make unicodedata "const"
Type: Stage: resolved
Components: Unicode Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, ezio.melotti, methane, vstinner
Priority: normal Keywords: patch

Created on 2019-04-16 12:49 by methane, last changed 2019-04-16 23:40 by methane. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12855 merged methane, 2019-04-16 12:54
Messages (3)
msg340336 - (view) Author: Inada Naoki (methane) * (Python committer) Date: 2019-04-16 12:49
diff --git a/Tools/unicode/makeunicodedata.py b/Tools/unicode/makeunicodedata.py
index 9327693a17..2550b8f940 100644
--- a/Tools/unicode/makeunicodedata.py
+++ b/Tools/unicode/makeunicodedata.py
@@ -1249,7 +1249,7 @@ class Array:
         size = getsize(self.data)
         if trace:
             print(self.name+":", size*len(self.data), "bytes", file=sys.stderr)
-        file.write("static ")
+        file.write("static const ")
         if size == 1:
             file.write("unsigned char")
         elif size == 2:
msg340337 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-04-16 12:52
Can you write a PR?
msg340372 - (view) Author: Inada Naoki (methane) * (Python committer) Date: 2019-04-16 23:40
New changeset 6fec905de5c139017f36b212e54cac46959808fe by Inada Naoki in branch 'master':
bpo-36642: make unicodedata const (GH-12855)
https://github.com/python/cpython/commit/6fec905de5c139017f36b212e54cac46959808fe
History
Date User Action Args
2019-04-16 23:40:49methanesetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-04-16 23:40:36methanesetmessages: + msg340372
2019-04-16 12:54:20methanesetkeywords: + patch
stage: patch review
pull_requests: + pull_request12781
2019-04-16 12:52:09vstinnersetmessages: + msg340337
2019-04-16 12:49:58methanecreate