This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: IDLE: Add search to textview.ViewWindow
Type: enhancement Stage: patch review
Components: IDLE Versions: Python 3.11
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: Shane Smith, ZackerySpytz, fhackdroid, terry.reedy
Priority: normal Keywords: patch

Created on 2019-04-11 00:12 by Shane Smith, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL Status Linked Edit
PR 17614 open ZackerySpytz, 2019-12-15 15:35
Messages (6)
msg339906 - (view) Author: Shane (Shane Smith) Date: 2019-04-11 00:12
Would it be possible to enhance IDLE's new Squeezed Output Viewer (which I LOVE, btw), with a text search feature?  If I'm in a module's help documentation, I'm usually looking for something, and I often end up copying the text into notepad and searching for it there.  Seems like text search would be a useful feature.

Thanks for reading,
msg339920 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-04-11 02:50
I agree.  The Squeezed Output Viewer is an instance of idlelib.textview.ViewWindow.  The latter is for read-only text and is also used for the text displays invoked from About IDLE.  I have already thought about making the text searchable.  Seaching does not require that the text be editable.

An initial implementatation might be a [Search] button that opens the current search dialog linked to the text in the window.
msg348315 - (view) Author: Farhaan Bukhsh (fhackdroid) * Date: 2019-07-23 04:25
Hey, this looks like an interesting feature. I want to take a stab at it. Terry can you help me understand the requirement better and may be mentor me to write it.
msg348317 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-07-23 04:54
If a ViewWindow has more that 24 lines, then it has a button bar at the bottom that currently has one button -- [Close].

1. Make the bar permanent, regardless of size.

The next steps are to adapt the editor code for Find.
2. Add another button [Search] or [Find] whose command generates a <find> pseudoevent.
3. Bind the find keys to <find>, as in the editor.
4 I believe <find> is already bound to the find_event function, but do so if needed.

This is more or less the same as in the editor, except that the button replaces the menu item.
msg358437 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2019-12-15 15:36
I have created a pull request for this issue.
msg413769 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2022-02-23 04:09
#46830 is a duplicate request.
History
Date User Action Args
2022-04-11 14:59:13adminsetgithub: 80776
2022-02-23 04:09:44terry.reedysetmessages: + msg413769
versions: + Python 3.11, - Python 3.8, Python 3.9
2022-02-23 04:08:28terry.reedylinkissue46830 superseder
2019-12-15 15:36:59ZackerySpytzsetnosy: + ZackerySpytz
messages: + msg358437
2019-12-15 15:35:56ZackerySpytzsetkeywords: + patch
stage: test needed -> patch review
pull_requests: + pull_request17086
2019-07-23 04:54:44terry.reedysettitle: IDLE: Add search to Squeezed Output text viewer. -> IDLE: Add search to textview.ViewWindow
messages: + msg348317
versions: + Python 3.9
2019-07-23 04:25:03fhackdroidsetnosy: + fhackdroid
messages: + msg348315
2019-04-11 04:43:05terry.reedysetversions: + Python 3.8
2019-04-11 02:50:22terry.reedysettitle: Text Search in Squeezed Output Viewer -> IDLE: Add search to Squeezed Output text viewer.
messages: + msg339920
stage: test needed
2019-04-11 00:12:01Shane Smithcreate