classification
Title: A possible crash in dictobject.c's new_dict()
Type: crash Stage: resolved
Components: Interpreter Core Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ZackerySpytz, inada.naoki
Priority: normal Keywords: patch

Created on 2019-03-24 01:49 by ZackerySpytz, last changed 2019-03-24 02:52 by inada.naoki. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12519 merged ZackerySpytz, 2019-03-24 01:52
Messages (3)
msg338711 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2019-03-24 01:49
PyDict_New() calls new_dict() with the "empty_values" array. If the PyObject_GC_New() call in new_dict() fails, new_dict() will call PyMem_FREE() on this array, causing a crash.
msg338712 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2019-03-24 02:23
New changeset 3d07c1ee1d2d475b74816117981d6ec752c26c23 by Inada Naoki (Zackery Spytz) in branch 'master':
bpo-36412: fix a possible crash in dictobject.c's new_dict() (GH-12519)
https://github.com/python/cpython/commit/3d07c1ee1d2d475b74816117981d6ec752c26c23
msg338713 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2019-03-24 02:52
Thank you, nice catch!
How did you find it?
History
Date User Action Args
2019-03-24 02:52:58inada.naokisetmessages: + msg338713
2019-03-24 02:23:44inada.naokisetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-03-24 02:23:36inada.naokisetnosy: + inada.naoki
messages: + msg338712
2019-03-24 01:52:29ZackerySpytzsetkeywords: + patch
stage: patch review
pull_requests: + pull_request12470
2019-03-24 01:49:34ZackerySpytzcreate