This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Typo in documentation of _PyObject_FastCallDict
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: remi.lapeyre, vstinner
Priority: normal Keywords: patch

Created on 2019-03-16 15:03 by remi.lapeyre, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12383 merged remi.lapeyre, 2019-03-17 18:11
PR 12402 merged remi.lapeyre, 2019-03-18 11:01
Messages (3)
msg338085 - (view) Author: Rémi Lapeyre (remi.lapeyre) * Date: 2019-03-16 15:03
Return result is documented as:

> Return the result on success. Raise an exception on return NULL on error.

I'm not absolutely sure but shouldn't that be "Raise an exception and return NULL on error."?

Or should it be "Raise an exception or return NULL on error."?
msg338204 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-03-18 11:51
New changeset 67294f64256a5cb29ca3c22d1a8d324e7ea177c6 by Victor Stinner (Rémi Lapeyre) in branch '3.7':
bpo-36317: Fix typo in _PyObject_FastCallDict documentation (GH-12383) (GH-12402)
https://github.com/python/cpython/commit/67294f64256a5cb29ca3c22d1a8d324e7ea177c6
msg338205 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-03-18 11:53
https://github.com/python/cpython/pull/12383 has been merged into master:

commit b4b97af8bed21e32eb77e7f7497acde1f8af4e70
Author: Rémi Lapeyre <remi.lapeyre@henki.fr>
Date:   Mon Mar 18 11:07:53 2019 +0100

    Fix typo in _PyObject_FastCallDict documentation (GH-12383)

Thanks Rémi Lapeyre.
History
Date User Action Args
2022-04-11 14:59:12adminsetgithub: 80498
2019-03-18 11:53:19vstinnersetstatus: open -> closed
versions: + Python 3.7
messages: + msg338205

resolution: fixed
stage: patch review -> resolved
2019-03-18 11:51:25vstinnersetmessages: + msg338204
2019-03-18 11:01:09remi.lapeyresetpull_requests: + pull_request12357
2019-03-17 18:11:27remi.lapeyresetkeywords: + patch
stage: patch review
pull_requests: + pull_request12341
2019-03-16 15:03:49remi.lapeyrecreate