classification
Title: test_os: add tests for invalid uid type
Type: Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, vstinner
Priority: normal Keywords: patch

Created on 2019-03-08 10:12 by vstinner, last changed 2019-03-11 13:20 by vstinner. This issue is now closed.

Files
File name Uploaded Description Edit
00157-uid-gid-overflows.patch vstinner, 2019-03-08 10:12
Pull Requests
URL Status Linked Edit
PR 12234 merged vstinner, 2019-03-08 10:28
PR 12235 merged vstinner, 2019-03-08 11:58
PR 12274 merged miss-islington, 2019-03-11 12:58
Messages (6)
msg337464 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-03-08 10:12
The Fedora package of python contains a downstream patch to add more tests for invalid uid types:
https://src.fedoraproject.org/rpms/python2/blob/master/f/00157-uid-gid-overflows.patch

I propose to make this patch upstream. More tests never hurts :-)

uid/gid overflow has been fixed bpo-4591.

The patch comes from:
https://bugzilla.redhat.com/show_bug.cgi?id=697470

Attached PRs add more tests.
msg337465 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-03-08 10:14
See _Py_Uid_Converter() and _Py_Gid_Converter() of Modules/posixmodule.c.
msg337663 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-03-11 12:57
New changeset 876e82b4f32075e1bd21750bf852a103035fce23 by Victor Stinner in branch 'master':
bpo-36234: Add more tests to PosixUidGidTests (GH-12234)
https://github.com/python/cpython/commit/876e82b4f32075e1bd21750bf852a103035fce23
msg337664 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-03-11 12:59
New changeset 701af605df336c9e32751e9031266a2da60656c1 by Victor Stinner in branch '2.7':
bpo-36234: test_os: check TypeError for invalid uid type (GH-12235)
https://github.com/python/cpython/commit/701af605df336c9e32751e9031266a2da60656c1
msg337665 - (view) Author: miss-islington (miss-islington) Date: 2019-03-11 13:18
New changeset 24872e1e15a816fb8e79c2885cafb7d785393547 by Miss Islington (bot) in branch '3.7':
bpo-36234: Add more tests to PosixUidGidTests (GH-12234)
https://github.com/python/cpython/commit/24872e1e15a816fb8e79c2885cafb7d785393547
msg337666 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-03-11 13:20
Thanks David Malcolm :-)
History
Date User Action Args
2019-03-11 13:20:42vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg337666

stage: patch review -> resolved
2019-03-11 13:18:54miss-islingtonsetnosy: + miss-islington
messages: + msg337665
2019-03-11 12:59:46vstinnersetmessages: + msg337664
2019-03-11 12:58:18miss-islingtonsetpull_requests: + pull_request12255
2019-03-11 12:57:57vstinnersetmessages: + msg337663
2019-03-08 11:58:18vstinnersetpull_requests: + pull_request12222
2019-03-08 10:28:15vstinnersetstage: patch review
pull_requests: + pull_request12221
2019-03-08 10:14:52vstinnersetmessages: + msg337465
2019-03-08 10:12:51vstinnersetfiles: + 00157-uid-gid-overflows.patch
keywords: + patch
2019-03-08 10:12:26vstinnercreate