This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Get rid of NamedStore
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.8
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: emilyemorehouse, gvanrossum, josh.r, serhiy.storchaka, tim.peters
Priority: normal Keywords: patch

Created on 2019-03-04 16:10 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12167 merged serhiy.storchaka, 2019-03-04 16:13
Messages (2)
msg337136 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-03-04 16:10
The proposed PR refactors the code for assignment expression and removes the NamedStore value of the expr_context_ty enum added in issue35224. This value is undistinguished from Store except two places in Python/ast.c and Python/symtable.c, but in that cases the difference can be handled at one level upper (when process the NamedExpr expression).

As a side effect this PR fixes the following minor bug:

>>> (True := 1)
  File "<stdin>", line 1
SyntaxError: cannot delete True
msg337236 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-03-05 18:42
New changeset d8b3a98c9098c66a714fd5593e1928af0ffbc631 by Serhiy Storchaka in branch 'master':
bpo-36187: Remove NamedStore. (GH-12167)
Date User Action Args
2022-04-11 14:59:12adminsetgithub: 80368
2019-03-05 18:57:36serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-03-05 18:42:18serhiy.storchakasetmessages: + msg337236
2019-03-04 17:31:50josh.rsetnosy: + josh.r
2019-03-04 16:13:48serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request12165
2019-03-04 16:10:00serhiy.storchakacreate