This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Avoid failing the build on race condition in clean
Type: compile error Stage: resolved
Components: Build, Windows Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: easy (C), patch

Created on 2019-02-25 19:32 by steve.dower, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12217 merged steve.dower, 2019-03-07 16:32
PR 12219 merged miss-islington, 2019-03-07 17:09
Messages (3)
msg336549 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-02-25 19:32
In PCbuild/openssl.props there is a task that deletes some copied files. 

This *might* fail on rebuilds where a Python process from a previous build has been running (for a very specific example, the rebuild as part of the release build triggered this).

We shouldn't need to fail the build in this case, so change the "TreatErrorsAsWarnings" attribute to "false"

(Note that this is not fixed by the KillPython step if the still-running executable is "python.exe" but we're building "python_d.exe" in the same folder. But warning and continuing is going to be fine for these particular files.)
msg337413 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-03-07 17:09
New changeset 2f8f56499c20af70ff5037fdbc5d738e56d9eab0 by Steve Dower in branch 'master':
bpo-36108: Avoid failing the build on race condition in clean (GH-12217)
https://github.com/python/cpython/commit/2f8f56499c20af70ff5037fdbc5d738e56d9eab0
msg337415 - (view) Author: miss-islington (miss-islington) Date: 2019-03-07 17:44
New changeset 34b398559fc47745473a39313a9e2ec17fe1d9ad by Miss Islington (bot) in branch '3.7':
bpo-36108: Avoid failing the build on race condition in clean (GH-12217)
https://github.com/python/cpython/commit/34b398559fc47745473a39313a9e2ec17fe1d9ad
History
Date User Action Args
2022-04-11 14:59:11adminsetgithub: 80289
2019-03-07 17:44:56miss-islingtonsetnosy: + miss-islington
messages: + msg337415
2019-03-07 17:13:12steve.dowersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-03-07 17:09:30miss-islingtonsetpull_requests: + pull_request12209
2019-03-07 17:09:17steve.dowersetmessages: + msg337413
2019-03-07 16:34:40steve.dowersetversions: + Python 3.7
2019-03-07 16:32:50steve.dowersetkeywords: + patch
stage: patch review
pull_requests: + pull_request12208
2019-02-25 19:32:52steve.dowercreate