➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2019-02-23 22:53 by cheryl.sabella, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 12002 | merged | cheryl.sabella, 2019-02-23 22:56 | |
| PR 12069 | closed | miss-islington, 2019-02-27 13:21 | |
| PR 12075 | merged | miss-islington, 2019-02-27 18:56 | |
| Messages (3) | |||
|---|---|---|---|
| msg336415 - (view) | Author: Cheryl Sabella (cheryl.sabella) *  |
Date: 2019-02-23 22:53 | |
From Terry's comment on PR11472 for issue 35689: > I don't like the use of class variables to initialize volatile instance state variables. I think it confuses the code a bit. Better, I think, to put them in an `init_state` method called from `__init__`. (I am not sure if method could be used in tests.) Since the tests do not access the class vars directly on the class, they should not be affected. I am leaving this minor refactoring for another issue after merging the tests. Then we can modify the class docstring. |
|||
| msg336757 - (view) | Author: Cheryl Sabella (cheryl.sabella) * |
Date: 2019-02-27 13:21 | |
New changeset ed1deb0719f0ac1b08a374e30ad26a701d4d51a2 by Cheryl Sabella in branch 'master': bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002) https://github.com/python/cpython/commit/ed1deb0719f0ac1b08a374e30ad26a701d4d51a2 |
|||
| msg336777 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2019-02-27 19:14 | |
New changeset 488aabafe2f1c5db05a6c1a7a8b49d7b89b1f36b by Terry Jan Reedy (Miss Islington (bot)) in branch '3.7': bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002) (GH-12075) https://github.com/python/cpython/commit/488aabafe2f1c5db05a6c1a7a8b49d7b89b1f36b |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:11 | admin | set | github: 80277 |
| 2019-02-27 19:24:28 | terry.reedy | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-02-27 19:14:10 | terry.reedy | set | messages: + msg336777 |
| 2019-02-27 18:56:12 | miss-islington | set | pull_requests: + pull_request12094 |
| 2019-02-27 13:21:42 | miss-islington | set | pull_requests: + pull_request12089 |
| 2019-02-27 13:21:19 | cheryl.sabella | set | messages: + msg336757 |
| 2019-02-23 22:56:12 | cheryl.sabella | set | keywords:
+ patch stage: patch review pull_requests: + pull_request12033 |
| 2019-02-23 22:53:18 | cheryl.sabella | create | |