classification
Title: python3.8 a1 - docs build requires sphinx 1.7 but uses a 1.8 feature
Type: Stage: resolved
Components: Build, Documentation Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Anthony Sottile, Mariatta, docs@python, miss-islington
Priority: normal Keywords: patch

Created on 2019-02-15 22:48 by Anthony Sottile, last changed 2019-02-15 23:51 by Mariatta. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11887 merged Anthony Sottile, 2019-02-15 23:34
Messages (4)
msg335654 - (view) Author: Anthony Sottile (Anthony Sottile) * Date: 2019-02-15 22:48
doctest `:skipif:` was added in https://github.com/sphinx-doc/sphinx/issues/5273

Used here: https://github.com/python/cpython/blame/36433221f06d649dbd7e13f5fec948be8ffb90af/Doc/library/turtle.rst#L252-L253

Sphinx minimum version configured here: https://github.com/python/cpython/blob/36433221f06d649dbd7e13f5fec948be8ffb90af/Doc/conf.py#L44-L45

Should this be upped to 1.8 or should the :skipif: be removed?  My guess is the former, I'd be happy to contribute a patch

I hit this while packaging 3.8.0a1 for deadsnakes
msg335655 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2019-02-15 23:16
Let's up the sphinx version. 
Thanks.
msg335658 - (view) Author: miss-islington (miss-islington) Date: 2019-02-15 23:41
New changeset a16ab00c0b8e126ab82e7cb5098af3ea32d315ff by Miss Islington (bot) (Anthony Sottile) in branch 'master':
bpo-36007: Bump minimum sphinx version to 1.8 (GH-11887)
https://github.com/python/cpython/commit/a16ab00c0b8e126ab82e7cb5098af3ea32d315ff
msg335659 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2019-02-15 23:41
Thanks!
History
Date User Action Args
2019-02-15 23:51:48Mariattasetversions: - Python 3.7
2019-02-15 23:41:42Mariattasetstatus: open -> closed
versions: + Python 3.7
messages: + msg335659

resolution: fixed
stage: patch review -> resolved
2019-02-15 23:41:18miss-islingtonsetnosy: + miss-islington
messages: + msg335658
2019-02-15 23:34:44Anthony Sottilesetkeywords: + patch
stage: patch review
pull_requests: + pull_request11917
2019-02-15 23:16:57Mariattasetnosy: + Mariatta
messages: + msg335655
2019-02-15 22:48:04Anthony Sottilecreate