classification
Title: Include Tcl/Tk 8.5.4 in the windows binary for the upcoming beta3
Type: Stage:
Components: Windows Versions: Python 3.0, Python 2.6
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: amaury.forgeotdarc, gpolo
Priority: normal Keywords:

Created on 2008-08-19 15:37 by gpolo, last changed 2009-08-06 22:55 by gpolo. This issue is now closed.

Messages (4)
msg71427 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2008-08-19 15:37
May I suggest the inclusion of Tcl/Tk 8.5.4 in the windows binary for
the upcoming beta3 ? beta2 included 8.5.3, but now the 8.5.4 bugfix
release arrived.
msg71441 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2008-08-19 16:13
Also, I was bitten by a runtime error because of an uninitialized variable.
It seems that the Microsoft compiler is able to detect uninitialized
values, in debug mode this causes a dialog to appear and IDLE crashes
when opening the "Save file" dialog.

In generic/tkFileFilter.c, the line 341
    if (ostypeCount > 0 && ostypeList != NULL)
should be replaced by
    if (ostypeList != NULL && ostypeCount > 0)

The problem still exists with 8.5.4.
msg71445 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2008-08-19 16:53
I don't know what this Microsoft compiler is doing but both ostypeCount
and ostypeList are properly set at Tcl_ListObjGetElements, and if that
call fails it skips to the bottom of this function you looked at.
msg71448 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2008-08-19 17:17
or not ? the indentation in this tkFileFilter.c is fooling me, the
Tcl_ListObjGetElements call is done in another block which is outside
that check, so the compiler seems to be right after all. It would be
good to report this problem at tk's bug tracker
(http://sourceforge.net/projects/tktoolkit).
History
Date User Action Args
2009-08-06 22:55:57gpolosetstatus: open -> closed
resolution: out of date
2008-08-19 17:17:04gpolosetmessages: + msg71448
2008-08-19 16:53:20gpolosetmessages: + msg71445
2008-08-19 16:13:37amaury.forgeotdarcsetnosy: + amaury.forgeotdarc
messages: + msg71441
2008-08-19 15:37:28gpolocreate