classification
Title: Enable Windows projects to build with platform ARM32
Type: enhancement Stage: resolved
Components: Build, Windows Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Paul Monson, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2019-02-12 04:02 by Paul Monson, last changed 2019-02-14 16:52 by steve.dower. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11825 merged Paul Monson, 2019-02-12 04:06
Messages (3)
msg335325 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-02-12 16:36
Just updating the title to reflect what the patch actually does in isolation - you probably should update the PR and NEWS items to match.

It's fine (probably preferred) to mention in the issue and PR text that it's been split out from another PR. But we have to account for the (very small) chance that this part is merged and the rest is not - in that case, having a standalone description of the change is much more helpful.
msg335538 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-02-14 16:31
New changeset 8a1657b93469580ef345c7c91738587f3d76e87d by Steve Dower (Paul Monson) in branch 'master':
bpo-35976: Enable Windows projects to build with platform ARM32 (GH-11825)
https://github.com/python/cpython/commit/8a1657b93469580ef345c7c91738587f3d76e87d
msg335545 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-02-14 16:52
Thanks, Paul! Hopefully when you rebase the main change on top of this it will be easier to see the actual impact.
History
Date User Action Args
2019-02-14 16:52:09steve.dowersetstatus: open -> closed
resolution: fixed
messages: + msg335545

stage: patch review -> resolved
2019-02-14 16:31:34steve.dowersetmessages: + msg335538
2019-02-12 16:36:57steve.dowersetmessages: + msg335325
title: PCBuild file changes for arm32 should be separated from code changes for review -> Enable Windows projects to build with platform ARM32
2019-02-12 04:06:36Paul Monsonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request11855
2019-02-12 04:02:51Paul Monsoncreate