classification
Title: Added thousands separators to Lib/pstats.py final report
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: SilentGhost, addons_zz
Priority: normal Keywords: patch, patch, patch

Created on 2019-01-29 12:52 by addons_zz, last changed 2019-05-18 20:24 by python-dev.

Pull Requests
URL Status Linked Edit
PR 11695 closed python-dev, 2019-01-29 12:52
PR 11695 closed python-dev, 2019-01-29 12:52
PR 11695 closed python-dev, 2019-01-29 12:52
PR 13411 open python-dev, 2019-05-18 20:24
Messages (2)
msg334513 - (view) Author: Addons Zz (addons_zz) Date: 2019-01-29 12:52
Instead of doing:
```
         10056.0 function calls in 0.006 seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
     1.0    0.002    0.002    0.006    0.006 benchmark_tests.py:121(logging_mod_log_debuglog_off)
  5000.0    0.002    0.000    0.004    0.000 F:\Python\lib\logging\__init__.py:1362(debug)
  5000.0    0.001    0.000    0.001    0.000 F:\Python\lib\logging\__init__.py:1620(isEnabledFor)
```

Do:
```
         10,056.0 function calls in 0.006 seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
      1.0    0.002    0.002    0.006    0.006 benchmark_tests.py:121(logging_mod_log_debuglog_off)
  5,000.0    0.002    0.000    0.004    0.000 F:\Python\lib\logging\__init__.py:1362(debug)
  5,000.0    0.001    0.000    0.001    0.000 F:\Python\lib\logging\__init__.py:1620(isEnabledFor)
```
msg334522 - (view) Author: SilentGhost (SilentGhost) * (Python triager) Date: 2019-01-29 14:32
Hi, your change breaks some test, most of the breakage is related to the change in whitespace separators. This breakages should be fixed before your PR can be considered for inclusion. You can see the status of the tests within discussion on github.
History
Date User Action Args
2019-05-18 20:24:17python-devsetpull_requests: + pull_request13322
2019-01-29 14:32:10SilentGhostsetkeywords: patch, patch, patch
nosy: + SilentGhost
messages: + msg334522

2019-01-29 12:52:44python-devsetkeywords: + patch
stage: patch review
pull_requests: + pull_request11541
2019-01-29 12:52:42python-devsetkeywords: + patch
stage: (no value)
pull_requests: + pull_request11540
2019-01-29 12:52:38python-devsetkeywords: + patch
stage: (no value)
pull_requests: + pull_request11539
2019-01-29 12:52:11addons_zzcreate