classification
Title: Python won't build with dtrace enabled on some systems.
Type: compile error Stage: patch review
Components: Build Versions: Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: kulikjak, lukasz.langa
Priority: normal Keywords: patch

Created on 2018-12-17 11:48 by kulikjak, last changed 2019-04-12 10:20 by kulikjak.

Pull Requests
URL Status Linked Edit
PR 11194 merged kulikjak, 2018-12-17 11:55
Messages (3)
msg331997 - (view) Author: Jakub Kulik (kulikjak) * Date: 2018-12-17 11:48
Python won't build on Solaris with dtrace support enabled.

Solaris is one of those systems where it is necessary to generate dtrace object files with dtrace -G. While this need is included in python configure and Makefiles, it doesn't work correctly.

First, configure tests -G support on file with not completely valid content of just BEGIN inside. Valid should have BEGIN{}. This is not a problem for systems that don't require dtrace object files as this test should fail for them anyway, however it incorrectly detects those like Solaris.

And second, Makefile is not ready for dtrace as the DTRACE_DEPS variable doesn't include all the necessary files.
msg334309 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2019-01-24 17:29
New changeset 5c8f537669d3379fc50bb0a96accac756e43e281 by Łukasz Langa (Jakub Kulík) in branch 'master':
bpo-35520: Fix build with dtrace support on certain systems. (#11194)
https://github.com/python/cpython/commit/5c8f537669d3379fc50bb0a96accac756e43e281
msg340020 - (view) Author: Jakub Kulik (kulikjak) * Date: 2019-04-12 10:20
Can this also be backported to 3.7? I just installed 3.8a3 (where it already is) and it works as expected.

Also we are using this patch ourselves in 3.7 and it works but I guess it would be nicer to have it in upstream as well.
History
Date User Action Args
2019-04-12 10:20:02kulikjaksetmessages: + msg340020
2019-01-24 17:29:54lukasz.langasetmessages: + msg334309
2018-12-18 21:32:08brett.cannonsetnosy: + lukasz.langa
2018-12-17 11:55:08kulikjaksetkeywords: + patch
stage: patch review
pull_requests: + pull_request10434
2018-12-17 11:48:50kulikjakcreate