classification
Title: Argument Clinic should use "const Py_UNICODE *" for the Py_UNICODE converter
Type: behavior Stage: resolved
Components: Argument Clinic Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: larry, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-12-14 08:53 by serhiy.storchaka, last changed 2018-12-14 09:57 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11150 merged serhiy.storchaka, 2018-12-14 08:57
PR 11151 merged serhiy.storchaka, 2018-12-14 09:23
Messages (3)
msg331787 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-12-14 08:53
Format units "Z" and "Z#" in PyArg_Parse* return a pointer to immutable internal data. Therefor the result of the Py_UNICODE converter in Argument Clinic should has type "const Py_UNICODE *".

This would help to catch the bug reported in issue31446.
msg331789 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-12-14 09:19
New changeset afb3e71a1710c444fbe789b51df43ee16ee9ede7 by Serhiy Storchaka in branch 'master':
bpo-35489: Use "const Py_UNICODE *" for the Py_UNICODE converter in AC. (GH-11150)
https://github.com/python/cpython/commit/afb3e71a1710c444fbe789b51df43ee16ee9ede7
msg331792 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-12-14 09:57
New changeset 45a7b7617e67bd1a8491f5e10ea9d24fe418b52d by Serhiy Storchaka in branch '3.7':
[3.7] bpo-35489: Use "const Py_UNICODE *" for the Py_UNICODE converter in AC. (GH-11150). (GH-11151)
https://github.com/python/cpython/commit/45a7b7617e67bd1a8491f5e10ea9d24fe418b52d
History
Date User Action Args
2018-12-14 09:57:23serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-12-14 09:57:01serhiy.storchakasetmessages: + msg331792
2018-12-14 09:23:51serhiy.storchakasetpull_requests: + pull_request10380
2018-12-14 09:19:55serhiy.storchakasetmessages: + msg331789
2018-12-14 08:57:49serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request10379
2018-12-14 08:53:53serhiy.storchakacreate