classification
Title: A deadly decref in _PyImport_FindExtensionObjectEx()
Type: behavior Stage: resolved
Components: Interpreter Core Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ZackerySpytz, eric.snow, miss-islington, serhiy.storchaka, xiang.zhang
Priority: normal Keywords: patch

Created on 2018-12-12 12:42 by ZackerySpytz, last changed 2019-01-10 16:44 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11128 merged ZackerySpytz, 2018-12-12 12:44
PR 11506 merged miss-islington, 2019-01-10 16:12
PR 11506 merged miss-islington, 2019-01-10 16:12
Messages (4)
msg331693 - (view) Author: Zackery Spytz (ZackerySpytz) * Date: 2018-12-12 12:42
In _PyImport_FindExtensionObjectEx(), "mod" shouldn't be decrefed if _PyState_AddModule() fails.
msg331695 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2018-12-12 13:35
What about version 3.6?
msg333394 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-01-10 16:12
New changeset 89c4f90df97f6039325e354167e8f507bf199fd9 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
bpo-35470: Fix a reference counting bug in _PyImport_FindExtensionObjectEx(). (GH-11128)
https://github.com/python/cpython/commit/89c4f90df97f6039325e354167e8f507bf199fd9
msg333399 - (view) Author: miss-islington (miss-islington) Date: 2019-01-10 16:36
New changeset 3e3d57d8490b729a80c8cd9e90475dec122dfe9e by Miss Islington (bot) in branch '3.7':
bpo-35470: Fix a reference counting bug in _PyImport_FindExtensionObjectEx(). (GH-11128)
https://github.com/python/cpython/commit/3e3d57d8490b729a80c8cd9e90475dec122dfe9e
History
Date User Action Args
2019-01-10 16:44:08serhiy.storchakasetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: - Python 3.6
2019-01-10 16:36:52miss-islingtonsetnosy: + miss-islington
messages: + msg333399
2019-01-10 16:12:55miss-islingtonsetpull_requests: + pull_request11048
2019-01-10 16:12:50miss-islingtonsetpull_requests: + pull_request11047
2019-01-10 16:12:35serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg333394
2018-12-12 19:25:17eric.snowsetnosy: + eric.snow

type: behavior
versions: + Python 3.6
2018-12-12 13:35:29xiang.zhangsetnosy: + xiang.zhang
messages: + msg331695
2018-12-12 12:44:40ZackerySpytzsetkeywords: + patch
stage: patch review
pull_requests: + pull_request10359
2018-12-12 12:42:37ZackerySpytzcreate