classification
Title: Solaris thread_time doesn't work with current implementation
Type: crash Stage: resolved
Components: Extension Modules Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: not a bug
Dependencies: Superseder:
Assigned To: Nosy List: kulikjak
Priority: normal Keywords: patch

Created on 2018-12-10 14:32 by kulikjak, last changed 2019-06-19 08:16 by kulikjak. This issue is now closed.

Files
File name Uploaded Description Edit
thread_time.diff kulikjak, 2018-12-10 14:32 Possible patch
Pull Requests
URL Status Linked Edit
PR 11118 closed kulikjak, 2018-12-11 12:48
Messages (2)
msg331509 - (view) Author: Jakub Kulik (kulikjak) * Date: 2018-12-10 14:32
Implementation of time.thread_time() doesn't work on Solaris because clock_id CLOCK_THREAD_CPUTIME_ID is not known (it is defined, but clock_gettime returns EINVAL error). Solaris, however, has function gethrvtime() which can substitute this functionality.

I attached a possible patch which does work during tests and I further tested it with some basic scripts.
msg346027 - (view) Author: Jakub Kulik (kulikjak) * Date: 2019-06-19 08:16
Since I created this pull request, clock_gettime(CLOCK_THREAD_CPUTIME_ID, ..) was implemented into the Solaris kernel, so I guess that this is no longer relevant.
History
Date User Action Args
2019-06-19 08:16:11kulikjaksetstatus: open -> closed
resolution: not a bug
messages: + msg346027

stage: patch review -> resolved
2018-12-11 15:40:15kulikjaksetversions: + Python 3.8
2018-12-11 12:48:31kulikjaksetstage: patch review
pull_requests: + pull_request10347
2018-12-11 10:22:59kulikjaksettype: crash
2018-12-10 14:32:21kulikjakcreate