classification
Title: global symbol "freegrammar" should be made static ore renamed
Type: Stage: resolved
Components: Interpreter Core Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, doko, serhiy.storchaka, steven.daprano
Priority: normal Keywords: patch

Created on 2018-11-28 17:17 by doko, last changed 2018-11-29 07:37 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 10788 merged benjamin.peterson, 2018-11-29 07:25
Messages (4)
msg330615 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2018-11-28 17:17
seen at least on the 2.7, a new symbol polluting the symbol namespace.
the global symbol "freegrammar" should be made static ore renamed
msg330663 - (view) Author: Steven D'Aprano (steven.daprano) * (Python committer) Date: 2018-11-29 06:44
What "freegrammar" symbol are you referring to?

Why should it be made static or renamed?

2.7 is something like a decade old now, why do you describe this as a new symbol?
msg330665 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-11-29 07:22
It was added in issue27780.
msg330666 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-11-29 07:37
New changeset 2e869a8f8280b5c786b3fde1f990e13927625e7a by Benjamin Peterson in branch '2.7':
closes bpo-35340: Add freegrammar to pgenheaders.h. (GH-10788)
https://github.com/python/cpython/commit/2e869a8f8280b5c786b3fde1f990e13927625e7a
History
Date User Action Args
2018-11-29 07:37:19benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg330666

stage: patch review -> resolved
2018-11-29 07:25:59benjamin.petersonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request10034
2018-11-29 07:22:58serhiy.storchakasetnosy: + serhiy.storchaka, benjamin.peterson
messages: + msg330665
2018-11-29 06:44:03steven.dapranosetnosy: + steven.daprano
messages: + msg330663
2018-11-28 17:17:11dokocreate