Title: Cmd.complete does not handle cmd=None
Type: behavior Stage: patch review
Components: Library (Lib) Versions: Python 3.8
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: blueyed, iritkatriel
Priority: normal Keywords: patch

Created on 2018-11-17 23:06 by blueyed, last changed 2021-09-07 14:24 by iritkatriel.

Pull Requests
URL Status Linked Edit
PR 10588 open blueyed, 2018-11-17 23:06
Messages (2)
msg330035 - (view) Author: daniel hahler (blueyed) * Date: 2018-11-17 23:06
When `parseline` returns `None` for `cmd` (like pdb++ might cause it when changing a cmd "disable" to "!disable"), the following will cause a TypeError:

> compfunc = getattr(self, 'complete_' + cmd)

"None" should be also forwarded to "completedefault", just like cmd="".
msg401285 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-09-07 14:24
Changing type since crash is typically used for a segfault rather than an exception.
Date User Action Args
2021-09-07 14:24:40iritkatrielsettype: crash -> behavior

messages: + msg401285
nosy: + iritkatriel
2018-11-17 23:06:25blueyedsetkeywords: + patch
stage: patch review
pull_requests: + pull_request9833
2018-11-17 23:06:01blueyedcreate