classification
Title: _Py_NO_RETURN is always empty on GCC
Type: behavior Stage: resolved
Components: Interpreter Core Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, berker.peksag, brett.cannon, izbyshev, miss-islington, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2018-11-02 16:03 by izbyshev, last changed 2018-11-03 02:37 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 10300 merged izbyshev, 2018-11-02 16:05
PR 10301 merged izbyshev, 2018-11-02 17:15
PR 10302 merged izbyshev, 2018-11-02 17:19
Messages (7)
msg329136 - (view) Author: Alexey Izbyshev (izbyshev) * (Python triager) Date: 2018-11-02 16:03
Non-existing __GNUC_MAJOR__ macro is used to check for GCC version at https://github.com/python/cpython/blob/b942707fc23454a998323c17e30be78ff1a4f0e7/Include/pyerrors.h#L97 . __GNUC__ should be used instead.
msg329137 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-11-02 16:06
Oh, this is common error!
msg329138 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-11-02 16:08
Oh right, the major version is __GNUC__:
https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
msg329139 - (view) Author: miss-islington (miss-islington) Date: 2018-11-02 16:32
New changeset e2ed5adcb5db2d70cfa72da1ba8446f7aa9e05cd by Miss Islington (bot) (Alexey Izbyshev) in branch 'master':
bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300)
https://github.com/python/cpython/commit/e2ed5adcb5db2d70cfa72da1ba8446f7aa9e05cd
msg329152 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-11-02 18:23
New changeset 29abad099535f4bcb1531df93bafbd75b26d6adc by Victor Stinner (Alexey Izbyshev) in branch '3.6':
[3.6] bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300) (GH-10302)
https://github.com/python/cpython/commit/29abad099535f4bcb1531df93bafbd75b26d6adc
msg329175 - (view) Author: miss-islington (miss-islington) Date: 2018-11-03 01:30
New changeset a9122d183b1fbc4484d72aec69fc0979c7fd91f2 by Miss Islington (bot) (Alexey Izbyshev) in branch '3.7':
[3.7] bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300) (GH-10301)
https://github.com/python/cpython/commit/a9122d183b1fbc4484d72aec69fc0979c7fd91f2
msg329177 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-11-03 02:37
Thanks Alexey Izbyshev!
History
Date User Action Args
2018-11-03 02:37:31vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg329177

stage: patch review -> resolved
2018-11-03 01:30:16miss-islingtonsetmessages: + msg329175
2018-11-02 18:23:58vstinnersetmessages: + msg329152
2018-11-02 17:19:06izbyshevsetpull_requests: + pull_request9612
2018-11-02 17:15:29izbyshevsetpull_requests: + pull_request9611
2018-11-02 16:32:30miss-islingtonsetnosy: + miss-islington
messages: + msg329139
2018-11-02 16:08:51vstinnersetnosy: + vstinner
messages: + msg329138
2018-11-02 16:06:21serhiy.storchakasetmessages: + msg329137
2018-11-02 16:05:02izbyshevsetkeywords: + patch
stage: patch review
pull_requests: + pull_request9609
2018-11-02 16:03:19izbyshevcreate