➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2018-11-02 16:03 by izbyshev, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 10300 | merged | izbyshev, 2018-11-02 16:05 | |
| PR 10301 | merged | izbyshev, 2018-11-02 17:15 | |
| PR 10302 | merged | izbyshev, 2018-11-02 17:19 | |
| Messages (7) | |||
|---|---|---|---|
| msg329136 - (view) | Author: Alexey Izbyshev (izbyshev) *  |
Date: 2018-11-02 16:03 | |
Non-existing __GNUC_MAJOR__ macro is used to check for GCC version at https://github.com/python/cpython/blob/b942707fc23454a998323c17e30be78ff1a4f0e7/Include/pyerrors.h#L97 . __GNUC__ should be used instead. |
|||
| msg329137 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2018-11-02 16:06 | |
Oh, this is common error! |
|||
| msg329138 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2018-11-02 16:08 | |
Oh right, the major version is __GNUC__: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html |
|||
| msg329139 - (view) | Author: miss-islington (miss-islington) | Date: 2018-11-02 16:32 | |
New changeset e2ed5adcb5db2d70cfa72da1ba8446f7aa9e05cd by Miss Islington (bot) (Alexey Izbyshev) in branch 'master': bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300) https://github.com/python/cpython/commit/e2ed5adcb5db2d70cfa72da1ba8446f7aa9e05cd |
|||
| msg329152 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2018-11-02 18:23 | |
New changeset 29abad099535f4bcb1531df93bafbd75b26d6adc by Victor Stinner (Alexey Izbyshev) in branch '3.6': [3.6] bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300) (GH-10302) https://github.com/python/cpython/commit/29abad099535f4bcb1531df93bafbd75b26d6adc |
|||
| msg329175 - (view) | Author: miss-islington (miss-islington) | Date: 2018-11-03 01:30 | |
New changeset a9122d183b1fbc4484d72aec69fc0979c7fd91f2 by Miss Islington (bot) (Alexey Izbyshev) in branch '3.7': [3.7] bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300) (GH-10301) https://github.com/python/cpython/commit/a9122d183b1fbc4484d72aec69fc0979c7fd91f2 |
|||
| msg329177 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2018-11-03 02:37 | |
Thanks Alexey Izbyshev! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:07 | admin | set | github: 79328 |
| 2018-11-03 02:37:31 | vstinner | set | status: open -> closed resolution: fixed messages: + msg329177 stage: patch review -> resolved |
| 2018-11-03 01:30:16 | miss-islington | set | messages: + msg329175 |
| 2018-11-02 18:23:58 | vstinner | set | messages: + msg329152 |
| 2018-11-02 17:19:06 | izbyshev | set | pull_requests: + pull_request9612 |
| 2018-11-02 17:15:29 | izbyshev | set | pull_requests: + pull_request9611 |
| 2018-11-02 16:32:30 | miss-islington | set | nosy:
+ miss-islington messages: + msg329139 |
| 2018-11-02 16:08:51 | vstinner | set | nosy:
+ vstinner messages: + msg329138 |
| 2018-11-02 16:06:21 | serhiy.storchaka | set | messages: + msg329137 |
| 2018-11-02 16:05:02 | izbyshev | set | keywords:
+ patch stage: patch review pull_requests: + pull_request9609 |
| 2018-11-02 16:03:19 | izbyshev | create | |