➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2018-10-26 17:26 by thatiparthy, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 10137 | merged | thatiparthy, 2018-10-26 17:30 | |
| Messages (6) | |||
|---|---|---|---|
| msg328651 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2018-10-27 15:04 | |
We don't usually do pure refactoring changes. |
|||
| msg328653 - (view) | Author: Karthikeyan Singaravelan (xtreak) * |
Date: 2018-10-27 16:29 | |
Serhiy, this adds a change where month's name CSS class is now customizable in LocaleHTMLCalendar. It's currently hard-coded as "month" though HTMLCalendar is customizable. I suggested method reuse since LocaleHTMLCalendar from HTMLCalendar that would fix this instead of duplicating the code. I think this can be reopened. |
|||
| msg328654 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-10-27 16:32 | |
Sorry, I was fooled by misleading titles and news entry. Please change them. |
|||
| msg328655 - (view) | Author: Karthikeyan Singaravelan (xtreak) * |
Date: 2018-10-27 16:43 | |
No problem, I have left a PR comment [0] to add the actual enhancement in the NEWS entry so that it's visible. The original issue title was "Allow customization of css class name of a month in calendar module" and @thatiparthy changed the issue title and PR to "Refactor code in calendar.py module" maybe due to my solution causing little confusion. @thatiparthy I am changing the issue title to "Allow customization of CSS class name of a month in calendar module" [0] https://github.com/python/cpython/pull/10137#pullrequestreview-169047050 Thanks |
|||
| msg335576 - (view) | Author: Cheryl Sabella (cheryl.sabella) * |
Date: 2019-02-15 00:00 | |
Issue 30095 enhanced the `HTMLCalendar` code to allow easier customization of the CSS classes. This PR extends that to the existing `LocaleHTMLCalendar`. Adding @doerwalter to the nosy list as he merged #30095. |
|||
| msg370604 - (view) | Author: Walter Dörwald (doerwalter) * |
Date: 2020-06-02 11:33 | |
New changeset 85339f5c220a5e79c47c3a33c93f1dca5c59c52e by Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) in branch 'master': bpo-35078: Allow customization of CSS class name of a month in calendar module (gh-10137) https://github.com/python/cpython/commit/85339f5c220a5e79c47c3a33c93f1dca5c59c52e |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:07 | admin | set | github: 79259 |
| 2020-06-02 17:19:33 | doerwalter | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-06-02 11:33:18 | doerwalter | set | messages: + msg370604 |
| 2019-02-15 00:00:40 | cheryl.sabella | set | nosy:
+ doerwalter, cheryl.sabella messages: + msg335576 |
| 2018-10-27 16:58:59 | serhiy.storchaka | set | nosy:
+ rhettinger |
| 2018-10-27 16:43:34 | xtreak | set | type: enhancement messages: + msg328655 title: Refactor code in calendar.py module -> Allow customization of CSS class name of a month in calendar module |
| 2018-10-27 16:32:49 | serhiy.storchaka | set | status: closed -> open resolution: rejected -> (no value) messages: + msg328654 stage: resolved -> patch review |
| 2018-10-27 16:29:07 | xtreak | set | messages: + msg328653 |
| 2018-10-27 15:04:58 | serhiy.storchaka | set | status: open -> closed nosy: + serhiy.storchaka messages: + msg328651 resolution: rejected stage: patch review -> resolved |
| 2018-10-27 06:51:16 | thatiparthy | set | title: Allow customization of css class name of a month in calendar module -> Refactor code in calendar.py module |
| 2018-10-26 18:07:26 | xtreak | set | nosy:
+ xtreak |
| 2018-10-26 17:30:44 | thatiparthy | set | keywords:
+ patch stage: patch review pull_requests: + pull_request9467 |
| 2018-10-26 17:26:56 | thatiparthy | create | |