This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: logger failure in suspicious.py
Type: behavior Stage: resolved
Components: Build Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: xtreak Nosy List: cjrh, miss-islington, pablogsal, xtreak
Priority: normal Keywords: patch

Created on 2018-10-21 06:56 by xtreak, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 10024 merged xtreak, 2018-10-21 07:03
PR 16637 merged miss-islington, 2019-10-08 03:39
Messages (4)
msg328191 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2018-10-21 06:56
There were some recent changes made in ee171a26c11 to fix Sphinx related deprecation warnings. During the change self.info() was changed to self.logger.info() . Logger expects a positional argument that contains the message thus causing failure. I think empty string can be passed here. I changed it back to self.info() and ran `make suspicious` locally and it only printed deprecation warning. Looking the source the previous method had message default to '' thus self.info() was working.

def info(self, message='', nonl=False):
    # type: (unicode, bool) > None
    """Emit an informational message.

    If *nonl* is true, don't emit a newline at the end (which implies that
    more info output will follow soon.)

    .. deprecated:: 1.6
       Use :mod:`sphinx.util.logging` instead.
    """
    warnings.warn('app.info() is now deprecated. Use sphinx.util.logging instead.',
                  RemovedInSphinx20Warning)
    logger.info(message, nonl=nonl)


Sample failure : https://travis-ci.org/python/cpython/jobs/444263040#L560

I am adding @pablogsal for thoughts on the fix. I will add a PR shortly.
msg328212 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-10-21 12:57
New changeset c3f52a59ce8406d9e59253ad4621e4749abdaeef by Pablo Galindo (Xtreak) in branch 'master':
bpo-35036: Remove empty log line in the suspicious.py tool (GH-10024)
https://github.com/python/cpython/commit/c3f52a59ce8406d9e59253ad4621e4749abdaeef
msg328213 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-10-21 12:58
Thanks @xtreak for the catch and PR!
msg354164 - (view) Author: miss-islington (miss-islington) Date: 2019-10-08 03:43
New changeset e78d79c15cc53bdf8161d41c627cbfb551d8ee96 by Miss Islington (bot) in branch '2.7':
bpo-35036: Remove empty log line in the suspicious.py tool (GH-10024)
https://github.com/python/cpython/commit/e78d79c15cc53bdf8161d41c627cbfb551d8ee96
History
Date User Action Args
2022-04-11 14:59:07adminsetgithub: 79217
2019-10-08 03:43:56miss-islingtonsetnosy: + miss-islington
messages: + msg354164
2019-10-08 03:39:40miss-islingtonsetpull_requests: + pull_request16222
2018-10-21 12:58:51pablogsalsetmessages: + msg328213
2018-10-21 12:58:34pablogsalsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-10-21 12:57:36pablogsalsetmessages: + msg328212
2018-10-21 07:52:32cjrhsetnosy: + cjrh
2018-10-21 07:03:11xtreaksetkeywords: + patch
stage: patch review
pull_requests: + pull_request9363
2018-10-21 06:56:59xtreaksetassignee: xtreak
2018-10-21 06:56:45xtreakcreate