classification
Title: batch file variables
Type: Stage:
Components: Build, Windows Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: eric.lindblad, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: easy

Created on 2018-09-30 17:55 by eric.lindblad, last changed 2018-11-27 23:52 by steve.dower.

Messages (2)
msg326735 - (view) Author: Eric Lindblad (eric.lindblad) Date: 2018-09-30 17:55
The development version code can set the variable EXTERNALS_DIR in two .bat files, but nowhere in a .bat file is set the variable EXTERNAL_DIR, the latter appearing in find_python.bat. I am not a Powershell user and so cannot interpret the content of the file .azure-pipelines/windows-steps.yml, where the variable EXTERNAL_DIR likewise appears, but, being familiar solely with .bat files would question whether a misprint had occurred in the below commit, as "%EXTERNAL_DIR%" rather than "%EXTERNALS_DIR%"?

https://github.com/python/cpython/commit/68d663cf85d1ac5eaf83482eed39c0a6f8093601#diff-60f6a0e6e49e5990c3ad465771fff9cd

committed on GitHub Jul 17, 2017
msg330562 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-11-27 23:52
Yep, good catch. That should be EXTERNALS_DIR in PCbuild/find_python.bat.
History
Date User Action Args
2018-11-27 23:52:52steve.dowersetversions: + Python 3.6, Python 3.7
nosy: + paul.moore, tim.golden, zach.ware, steve.dower

messages: + msg330562

components: + Windows
keywords: + easy
2018-09-30 17:55:56eric.lindbladcreate