This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: test_ssl.test_default_ecdh_curve needs no tls1.3 flag in 2.7, for now
Type: Stage: resolved
Components: Versions: Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: christian.heimes Nosy List: christian.heimes, cstratak, ncoghlan, xnox, zach.ware
Priority: normal Keywords: patch

Created on 2018-09-28 16:32 by xnox, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9626 merged xnox, 2018-09-28 16:34
Messages (3)
msg326644 - (view) Author: Dimitri John Ledkov (xnox) * Date: 2018-09-28 16:32
test_default_ecdh_curve fails, as ssl.OP_NO_TLSv1_3 is not set on the context. and the test case can only work with non-tls1.3 connections.

this indicates that the pull request that sprinkled ssl.OP_NO_TLSv1_3 everywhere was not backported, taking into account all the other backports that did subsequently remove those flags in many test cases.

at the moment that test case is failing, but it would be nice if it didn't.
msg345071 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2019-06-09 05:45
New changeset 99b5c940d3471e0ed6579771d94e7342d7c733e0 by Nick Coghlan (Dimitri John Ledkov) in branch '2.7':
[2.7] bpo-34836: fix test_default_ecdh_curve, needs no tlsv1.3. (GH-9626)
msg367372 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2020-04-27 03:37
This seems to have been fixed, so I'm closing it as such.  With 2.7 at EOL, this would be closed anyway, but "fixed" sounds nicer :)
Date User Action Args
2022-04-11 14:59:06adminsetgithub: 79017
2020-04-27 03:37:00zach.waresetstatus: open -> closed

nosy: + zach.ware
messages: + msg367372

resolution: fixed
stage: patch review -> resolved
2019-06-09 05:45:09ncoghlansetnosy: + ncoghlan
messages: + msg345071
2018-12-26 22:13:34gregory.p.smithsetassignee: christian.heimes
2018-10-01 19:42:06cstrataksetnosy: + cstratak
2018-09-28 17:39:30xtreaksetnosy: + christian.heimes
2018-09-28 16:34:40xnoxsetkeywords: + patch
stage: patch review
pull_requests: + pull_request9024
2018-09-28 16:32:44xnoxcreate