Title: test_ssl.test_default_ecdh_curve needs no tls1.3 flag in 2.7, for now
Type: Stage: patch review
Components: Versions: Python 2.7
Status: open Resolution:
Dependencies: Superseder:
Assigned To: christian.heimes Nosy List: christian.heimes, cstratak, ncoghlan, xnox
Priority: normal Keywords: patch

Created on 2018-09-28 16:32 by xnox, last changed 2019-06-09 05:45 by ncoghlan.

Pull Requests
URL Status Linked Edit
PR 9626 merged xnox, 2018-09-28 16:34
Messages (2)
msg326644 - (view) Author: Dimitri John Ledkov (xnox) * Date: 2018-09-28 16:32
test_default_ecdh_curve fails, as ssl.OP_NO_TLSv1_3 is not set on the context. and the test case can only work with non-tls1.3 connections.

this indicates that the pull request that sprinkled ssl.OP_NO_TLSv1_3 everywhere was not backported, taking into account all the other backports that did subsequently remove those flags in many test cases.

at the moment that test case is failing, but it would be nice if it didn't.
msg345071 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2019-06-09 05:45
New changeset 99b5c940d3471e0ed6579771d94e7342d7c733e0 by Nick Coghlan (Dimitri John Ledkov) in branch '2.7':
[2.7] bpo-34836: fix test_default_ecdh_curve, needs no tlsv1.3. (GH-9626)
Date User Action Args
2019-06-09 05:45:09ncoghlansetnosy: + ncoghlan
messages: + msg345071
2018-12-26 22:13:34gregory.p.smithsetassignee: christian.heimes
2018-10-01 19:42:06cstrataksetnosy: + cstratak
2018-09-28 17:39:30xtreaksetnosy: + christian.heimes
2018-09-28 16:34:40xnoxsetkeywords: + patch
stage: patch review
pull_requests: + pull_request9024
2018-09-28 16:32:44xnoxcreate