classification
Title: IDLE: use theme colors for help viewer
Type: enhancement Stage: patch review
Components: IDLE Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: cheryl.sabella, terry.reedy
Priority: normal Keywords: patch

Created on 2018-09-23 05:34 by terry.reedy, last changed 2018-09-23 13:02 by cheryl.sabella.

Pull Requests
URL Status Linked Edit
PR 9502 open terry.reedy, 2018-09-23 05:53
Messages (4)
msg326133 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-09-23 05:34
Follow-up to #34548.  Use user-selected color theme for Help => IDLE Help.  (Patch coming.)
msg326135 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-09-23 06:09
If HelpText is ever subclassed from a view text class, the color_config and call will be deleted.  But changing the two fixed colors will be needed in any case.

The background option in
  self.tag_configure('pre', font=(fixedfont, 12), background='#f6f6ff')
was intended to give fixed-pitch words a very light bluish background, but I cannot see any difference, so deleting it is no loss.

For the pre block, "background='#eeffcc'" gives the block a yellow background that matches the one used in online docs, as viewed by me with Firefox.  So it is made conditional on the foreground color being the default solid black (which is different from tk's 'black').

Border colors appear to be fixed at some black, making the border invisible on a black or near-black background.  But it does not seem worthwhile to try to decide when to omit it.
msg326136 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-09-23 06:09
I have tested this on Windows with both light and dark themes.
msg326151 - (view) Author: Cheryl Sabella (cheryl.sabella) * (Python committer) Date: 2018-09-23 13:02
This is working on Ubuntu.  Probably not a big deal, but because the help viewer is not modal, it's possible to change the theme with the help window open and the text isn't updated on the help window.  If the help is closed and reopened, then the new theme appears.
History
Date User Action Args
2018-09-23 13:02:05cheryl.sabellasetnosy: + cheryl.sabella
messages: + msg326151
2018-09-23 06:09:58terry.reedysetmessages: + msg326136
2018-09-23 06:09:12terry.reedysetassignee: terry.reedy
messages: + msg326135
components: + IDLE
2018-09-23 05:53:08terry.reedysetkeywords: + patch
pull_requests: + pull_request8909
2018-09-23 05:34:58terry.reedycreate