➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Get rid of tp_getattro in xml.etree.ElementTree.XMLParser
Type: enhancement Stage: resolved
Components: Extension Modules Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: eli.bendersky, scoder, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-09-19 14:25 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9420 merged serhiy.storchaka, 2018-09-19 14:27
Messages (3)
msg325766 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-09-19 14:25 
Currently xml.etree.ElementTree.XMLParser has the tp_getattro slot for handling some attributes. The proposed PR replaces it with tp_members and tp_getset.

Benefits: constant time access, names of these attributes are added to the result of dir() and help(), better structured code.
msg325774 - (view) Author: Stefan Behnel (scoder) * (Python committer) Date: 2018-09-19 16:27 
Nice. Looks good to me.
msg327040 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-10-04 07:41 
New changeset b2953fa3dda5898fcb0029792d9229f150e6e2cb by Serhiy Storchaka in branch 'master':
bpo-34739: Get rid of tp_getattro in xml.etree.ElementTree.XMLParser. (GH-9420)
https://github.com/python/cpython/commit/b2953fa3dda5898fcb0029792d9229f150e6e2cb
History
Date User Action Args
2022-04-11 14:59:06adminsetgithub: 78920
2018-10-04 07:43:39serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-10-04 07:41:32serhiy.storchakasetmessages: + msg327040
2018-09-19 16:27:23scodersetmessages: + msg325774
2018-09-19 14:27:08serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request8840
2018-09-19 14:25:12serhiy.storchakacreate