classification
Title: make the eval loop more editable
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson
Priority: normal Keywords: patch

Created on 2018-09-14 04:14 by benjamin.peterson, last changed 2018-09-17 05:38 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9289 merged benjamin.peterson, 2018-09-14 04:15
Messages (2)
msg325320 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-14 04:14
The TARGET macro in ceval.c hides control flow, most importantly the case statement. This confuses my editor and makes it indent things automatically improperly. This can be fixed by moving the case statements out of the TARGET macro.
msg325512 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-17 05:38
New changeset ddd1949fea59f256e51191540a4446f75ed608fa by Benjamin Peterson in branch 'master':
closes bpo-34673: Tweaks to make ceval more editable. (GH-9289)
https://github.com/python/cpython/commit/ddd1949fea59f256e51191540a4446f75ed608fa
History
Date User Action Args
2018-09-17 05:38:13benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg325512

stage: patch review -> resolved
2018-09-14 04:15:54benjamin.petersonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request8720
2018-09-14 04:14:32benjamin.petersoncreate