This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: remove the configure check TANH_PRESERVES_ZERO_SIGN
Type: Stage: resolved
Components: Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, mark.dickinson
Priority: normal Keywords: patch

Created on 2018-09-12 00:26 by benjamin.peterson, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9206 merged benjamin.peterson, 2018-09-12 00:28
Messages (3)
msg325106 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-12 00:26
configure.ac currently has to check for a bug in FreeBSD 6.2:

# On FreeBSD 6.2, it appears that tanh(-0.) returns 0. instead of
# -0. on some architectures.
AC_MSG_CHECKING(whether tanh preserves the sign of zero)
...

FreeBSD 6.2 is nearing 12 years old. It looks like the FreeBSD 10 bot is passing this check. So, I think we should remove this configure check.
msg325134 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2018-09-12 12:06
> So, I think we should remove this configure check.

+1.
msg325138 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-12 13:51
New changeset 865c17fb28f8c3275fd94da6ee4ac51472ec874a by Benjamin Peterson in branch 'master':
closes bpo-34640: Remove the TANH_PRESERVES_ZERO_SIGN configure check. (GH-9206)
https://github.com/python/cpython/commit/865c17fb28f8c3275fd94da6ee4ac51472ec874a
History
Date User Action Args
2022-04-11 14:59:05adminsetgithub: 78821
2018-09-12 13:51:28benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg325138

stage: patch review -> resolved
2018-09-12 12:06:37mark.dickinsonsetmessages: + msg325134
2018-09-12 00:28:13benjamin.petersonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request8640
2018-09-12 00:26:31benjamin.petersoncreate