classification
Title: Windows : use of __pragma msvc extension without ifdef
Type: compile error Stage: resolved
Components: Extension Modules Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, erikjanss, miss-islington
Priority: normal Keywords: patch

Created on 2018-09-04 21:05 by erikjanss, last changed 2018-09-05 06:45 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9067 merged erikjanss, 2018-09-04 21:10
PR 9070 merged miss-islington, 2018-09-05 06:29
Messages (3)
msg324603 - (view) Author: Erik Janssens (erikjanss) * Date: 2018-09-04 21:05
The socketmodule uses the MSVC extension __pragma.

The use of this extension is not enabled/disable by an #ifdef _MSC_VER.

This prevents compilation with other compilers then MSVC on Windows.
msg324608 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-09-05 06:29
New changeset 874809ea389e6434787e773a6054a08e0b81f734 by Benjamin Peterson (Erik Janssens) in branch 'master':
closes bpo-34581 : Conditionalize use of __pragma in Modules/socketmodule.c. (GH-9067)
https://github.com/python/cpython/commit/874809ea389e6434787e773a6054a08e0b81f734
msg324609 - (view) Author: miss-islington (miss-islington) Date: 2018-09-05 06:45
New changeset 5b17d7fccd8f0b4d5030b03924eb00904585ba31 by Miss Islington (bot) in branch '3.7':
closes bpo-34581 : Conditionalize use of __pragma in Modules/socketmodule.c. (GH-9067)
https://github.com/python/cpython/commit/5b17d7fccd8f0b4d5030b03924eb00904585ba31
History
Date User Action Args
2018-09-05 06:45:07miss-islingtonsetnosy: + miss-islington
messages: + msg324609
2018-09-05 06:29:58miss-islingtonsetpull_requests: + pull_request8529
2018-09-05 06:29:47benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg324608

resolution: fixed
stage: patch review -> resolved
2018-09-04 21:10:39erikjansssetkeywords: + patch
stage: patch review
pull_requests: + pull_request8526
2018-09-04 21:05:20erikjansscreate