classification
Title: Arguments missing from documentation for HTTPErrorProcessor.http(s)_response()
Type: behavior Stage: resolved
Components: Documentation Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: berker.peksag, docs@python, miss-islington, srittau
Priority: normal Keywords: patch

Created on 2018-08-17 07:45 by srittau, last changed 2018-08-17 10:37 by berker.peksag. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8793 merged srittau, 2018-08-17 07:53
PR 8794 merged miss-islington, 2018-08-17 09:48
PR 8795 merged miss-islington, 2018-08-17 09:48
Messages (5)
msg323638 - (view) Author: Sebastian Rittau (srittau) * Date: 2018-08-17 07:45
The documentation at https://docs.python.org/3/library/urllib.request.html#urllib.request.HTTPErrorProcessor does not list the two arguments "request" and "response" that HTTPErrorProcessor.http_response() and https_response() actually require. (I checked the implementation in Python 3.5 and 3.7.)
msg323641 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-08-17 09:47
New changeset c53aaec793e018edef4e72a3edbd338b10db10aa by Berker Peksag (Sebastian Rittau) in branch 'master':
bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
https://github.com/python/cpython/commit/c53aaec793e018edef4e72a3edbd338b10db10aa
msg323643 - (view) Author: miss-islington (miss-islington) Date: 2018-08-17 10:02
New changeset 05d89ef785ab3cb6dd28f10f312f68f8e6a163ce by Miss Islington (bot) in branch '3.7':
bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
https://github.com/python/cpython/commit/05d89ef785ab3cb6dd28f10f312f68f8e6a163ce
msg323645 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-08-17 10:35
New changeset 02c4d4b6dcd772ec3a7fdca517118f3fa53b0b88 by Berker Peksag (Miss Islington (bot)) in branch '3.6':
bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
https://github.com/python/cpython/commit/02c4d4b6dcd772ec3a7fdca517118f3fa53b0b88
msg323646 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-08-17 10:37
Thanks for the report and for the patch! 3.5 is in security-fix-only mode, so it doesn't get documentation fixes anymore.
History
Date User Action Args
2018-08-17 10:37:24berker.peksagsetstatus: open -> closed
versions: + Python 3.6, Python 3.8, - Python 3.5
type: behavior
messages: + msg323646

resolution: fixed
stage: patch review -> resolved
2018-08-17 10:35:55berker.peksagsetmessages: + msg323645
2018-08-17 10:02:14miss-islingtonsetnosy: + miss-islington
messages: + msg323643
2018-08-17 09:48:34miss-islingtonsetpull_requests: + pull_request8270
2018-08-17 09:48:23miss-islingtonsetpull_requests: + pull_request8269
2018-08-17 09:47:35berker.peksagsetnosy: + berker.peksag
messages: + msg323641
2018-08-17 07:53:41srittausetkeywords: + patch
stage: patch review
pull_requests: + pull_request8267
2018-08-17 07:45:47srittaucreate