classification
Title: Move note about repeated calls to json.dump using the same fp to the json.dump section
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, eallrich, inada.naoki, miss-islington
Priority: normal Keywords: patch

Created on 2018-08-10 22:10 by eallrich, last changed 2018-08-11 09:13 by inada.naoki. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8730 merged eallrich, 2018-08-10 22:20
PR 8735 merged miss-islington, 2018-08-11 07:34
PR 8736 merged miss-islington, 2018-08-11 07:34
Messages (4)
msg323396 - (view) Author: Evan Allrich (eallrich) * Date: 2018-08-10 22:10
At present the note [0] appears under the documentation for `json.dumps` (which does not use the `fp` argument). It seems the note would be better placed with the documentation for the affected function.

[0] 
> Note
> 
> Unlike pickle and marshal, JSON is not a framed protocol, so trying to > serialize multiple objects with repeated calls to dump() using the same > fp will result in an invalid JSON file.
msg323407 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2018-08-11 07:34
New changeset 9e840848510d20e644a19c723b803877377d3765 by INADA Naoki (Evan Allrich) in branch 'master':
bpo-34379: Doc: Move note for json.dump (GH-8730)
https://github.com/python/cpython/commit/9e840848510d20e644a19c723b803877377d3765
msg323408 - (view) Author: miss-islington (miss-islington) Date: 2018-08-11 08:02
New changeset 6b145085225d4b114b4422f6d3c6e859e75b97d7 by Miss Islington (bot) in branch '3.7':
bpo-34379: Doc: Move note for json.dump (GH-8730)
https://github.com/python/cpython/commit/6b145085225d4b114b4422f6d3c6e859e75b97d7
msg323409 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2018-08-11 09:13
New changeset eb6ed12f486f184cb00fc35662d012dbb1f30d2e by INADA Naoki (Miss Islington (bot)) in branch '3.6':
bpo-34379: Doc: Move note for json.dump (GH-8730)
https://github.com/python/cpython/commit/eb6ed12f486f184cb00fc35662d012dbb1f30d2e
History
Date User Action Args
2018-08-11 09:13:33inada.naokisetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: + Python 3.6, Python 3.8
2018-08-11 09:13:10inada.naokisetmessages: + msg323409
2018-08-11 08:02:11miss-islingtonsetnosy: + miss-islington
messages: + msg323408
2018-08-11 07:34:26miss-islingtonsetpull_requests: + pull_request8223
2018-08-11 07:34:20miss-islingtonsetpull_requests: + pull_request8222
2018-08-11 07:34:04inada.naokisetnosy: + inada.naoki
messages: + msg323407
2018-08-10 22:20:18eallrichsetkeywords: + patch
stage: patch review
pull_requests: + pull_request8215
2018-08-10 22:10:19eallrichcreate