This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: bufferedio.c uses unused argument of METH_NOARGS functions
Type: Stage: resolved
Components: Extension Modules Versions: Python 3.8
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: jdemeyer, methane, rhettinger, scoder
Priority: normal Keywords: patch

Created on 2018-07-31 07:07 by jdemeyer, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8582 merged jdemeyer, 2018-07-31 07:09
Messages (2)
msg322736 - (view) Author: Jeroen Demeyer (jdemeyer) * (Python triager) Date: 2018-07-31 07:07
A METH_NOARGS function has a second unused argument which is always NULL (this is guaranteed by the documentation).

However, some functions in Modules/_io/bufferedio.c actually that second NULL argument. This is technically not a bug, but it looks more clear to explicitly mark that second argument as unused.
msg322945 - (view) Author: Inada Naoki (methane) * (Python committer) Date: 2018-08-02 11:14
New changeset fc512e3e0663f7f325862fcd42aef765fd34a453 by INADA Naoki (jdemeyer) in branch 'master':
bpo-34287: Do not use second argument of METH_NOARGS functions (GH-8582)
Date User Action Args
2022-04-11 14:59:04adminsetgithub: 78468
2018-08-02 11:15:25methanesetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-08-02 11:14:57methanesetnosy: + methane
messages: + msg322945
2018-07-31 07:09:14jdemeyersetkeywords: + patch
stage: patch review
pull_requests: + pull_request8091
2018-07-31 07:07:43jdemeyercreate