classification
Title: Make ndarray.readonly a bool
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: serhiy.storchaka, skrah
Priority: normal Keywords: patch

Created on 2018-07-23 14:01 by serhiy.storchaka, last changed 2018-07-26 13:14 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8414 merged serhiy.storchaka, 2018-07-23 14:05
PR 8481 merged serhiy.storchaka, 2018-07-26 13:14
Messages (2)
msg322221 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-07-23 14:01
memoryview.readonly is a bool, but ndarray.readonly is an int 0 or 1. The proposed PR makes ndarray.readonly a bool and makes test_buffer using more strict assertIs() instead of assertEqual() for testing boolean values.
msg322412 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-07-26 10:23
New changeset e0d67f17ccb4645ff88c9a018679b8a5b4fe0a7e by Serhiy Storchaka in branch 'master':
bpo-34201: Make ndarray.readonly a bool and use stricter tests in test_buffer. (GH-8414)
https://github.com/python/cpython/commit/e0d67f17ccb4645ff88c9a018679b8a5b4fe0a7e
History
Date User Action Args
2018-07-26 13:14:25serhiy.storchakasetpull_requests: + pull_request8004
2018-07-26 11:26:19serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-07-26 10:23:06serhiy.storchakasetmessages: + msg322412
2018-07-23 14:05:28serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request7940
2018-07-23 14:01:22serhiy.storchakacreate