classification
Title: IDLE: use ttk.Frame for ttk widgets
Type: enhancement Stage: resolved
Components: IDLE Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: cheryl.sabella, markroseman, miss-islington, terry.reedy
Priority: normal Keywords: patch, patch, patch

Created on 2018-06-28 04:02 by markroseman, last changed 2019-01-04 23:58 by cheryl.sabella. This issue is now closed.

Files
File name Uploaded Description Edit
topframe.png markroseman, 2018-06-28 04:02
Pull Requests
URL Status Linked Edit
PR 11395 merged terry.reedy, 2018-12-31 22:12
PR 11419 merged miss-islington, 2019-01-03 03:04
PR 11433 open cheryl.sabella, 2019-01-04 23:50
Messages (7)
msg320646 - (view) Author: Mark Roseman (markroseman) * Date: 2018-06-28 04:02
When adding a bunch of ttk widgets into a toplevel window, there needs to be an intervening ttk.Frame to ensure the background of the widgets matches the overall background.

The reason is the 'toplevel' is part of the classic tk widgets and not ttk, so it isn't guaranteed to have the same background. In practice, the only platform where the toplevel and ttk.Frame have different backgrounds is macOS. Check out topframe.png for an example, top is without the intervening ttk.Frame, bottom adds it in.

(Adding bug mainly so we have a place to store a concrete example of what this looks like)
msg320800 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-30 18:08
The image could have been attached to #27477, but a new issue for a new PR is needed anyway.  I will make this a dependency of that issue.

I did not at first see the difference in the screen-capture images on my monitor in Firefox with the room lighting and my eye condition as it was then, but today I do.  On Mac, the defaulf ttk background is slightly darker than the default tk background.  (No so on Windows.)  It looks subtlely tacky.  I imagine this effect might be more obvious and annoying on the live screen.

As I mentioned elsewhere, this is a second reason to insert a frame inside Toplevel, but it is a reason to do this *now*.  Please submit a PR for this addition to searchbase: a new ttk Frame, with a bit of space added.  Please call it self.frame as in query or perhaps self.searchframe, analogous to viewframe in textview.

When SearchDialogBase is renamed SearchFrameBase(Frame) and the toplevel stuff moved to another class, self.???frame in the Frame subclass will become self, so the name will only appear in the toplevel class.

In test_searchbase.SearchDialogBaseTest.test_open_and_close, adding
        self.assertEqual(self.dialog.frame.state(), 'normal')
will test the change, failing now, passing with it.  I don't know of any other changes needed in files other than searchbase.

configdialog needs a similar PR.  config_key needs a complete ttk conversion.
msg332835 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-12-31 21:38
*35598 converted config_key to ttk, including a t tk frame inside toplevel.
msg332837 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-12-31 22:08
The change is trivial and there was already a Frame test, which initially failed.  I will open another issue about similar changes needed elsewhere.
msg332839 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-12-31 22:30
We don't really need a new issue.  Mark's opening post was generic.  I grepped for ttk to get existing ttk imports and am making Frame and LabelFrame the first item or items for each import.  I won't worry about whether any background is visible, as this could change.

Cheryl, please note the import convention and review the diff when posted.
msg332904 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-01-03 03:04
New changeset aff0adabf3ace62073076f4ce875ff568f2d3180 by Terry Jan Reedy in branch 'master':
bpo-33987: IDLE - use ttk Frame for ttk widgets (GH-11395)
https://github.com/python/cpython/commit/aff0adabf3ace62073076f4ce875ff568f2d3180
msg332905 - (view) Author: miss-islington (miss-islington) Date: 2019-01-03 03:22
New changeset b364caa39999658e843151602356e527851d6c68 by Miss Islington (bot) in branch '3.7':
bpo-33987: IDLE - use ttk Frame for ttk widgets (GH-11395)
https://github.com/python/cpython/commit/b364caa39999658e843151602356e527851d6c68
History
Date User Action Args
2019-01-04 23:58:18cheryl.sabellasetpull_requests: - pull_request10861
2019-01-04 23:58:05cheryl.sabellasetpull_requests: - pull_request10860
2019-01-04 23:50:45cheryl.sabellasetpull_requests: + pull_request10861
2019-01-04 23:50:37cheryl.sabellasetpull_requests: + pull_request10860
2019-01-04 23:50:28cheryl.sabellasetpull_requests: + pull_request10859
2019-01-03 05:59:25terry.reedysetkeywords: patch, patch, patch
status: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-01-03 03:22:14miss-islingtonsetnosy: + miss-islington
messages: + msg332905
2019-01-03 03:16:05terry.reedysetpull_requests: - pull_request10827
2019-01-03 03:15:47terry.reedysetpull_requests: - pull_request10828
2019-01-03 03:04:34miss-islingtonsetstage: test needed -> patch review
pull_requests: + pull_request10828
2019-01-03 03:04:29miss-islingtonsetstage: test needed -> test needed
pull_requests: + pull_request10827
2019-01-03 03:04:24miss-islingtonsetstage: test needed -> test needed
pull_requests: + pull_request10826
2019-01-03 03:04:10terry.reedysetmessages: + msg332904
2018-12-31 23:18:17terry.reedysetpull_requests: - pull_request10772
2018-12-31 23:18:02terry.reedysetpull_requests: - pull_request10773
2018-12-31 22:30:39terry.reedysetkeywords: patch, patch, patch

title: IDLE: add ttk.Frame inside searchbaseToplevel -> IDLE: use ttk.Frame for ttk widgets
messages: + msg332839
stage: patch review -> test needed
2018-12-31 22:13:00terry.reedysetkeywords: + patch
stage: test needed -> patch review
pull_requests: + pull_request10773
2018-12-31 22:12:53terry.reedysetkeywords: + patch
stage: test needed -> test needed
pull_requests: + pull_request10772
2018-12-31 22:12:45terry.reedysetkeywords: + patch
stage: test needed -> test needed
pull_requests: + pull_request10771
2018-12-31 22:08:47terry.reedysetnosy: + cheryl.sabella
messages: + msg332837
2018-12-31 21:38:45terry.reedysetmessages: + msg332835
2018-12-11 23:24:41terry.reedysetversions: - Python 3.6
2018-06-30 18:44:04terry.reedylinkissue27477 dependencies
2018-06-30 18:08:29terry.reedysettitle: need ttk.Frame inside Toplevel(s) -> IDLE: add ttk.Frame inside searchbaseToplevel
messages: + msg320800
stage: test needed
2018-06-28 04:02:30markrosemancreate