classification
Title: test_gdb is skipped in builds since gdb is not installed as part of build script
Type: Stage: patch review
Components: Build, Tests Versions: Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: inada.naoki, jdemeyer, miss-islington, vstinner, xtreak, zach.ware
Priority: normal Keywords: patch

Created on 2018-06-21 10:35 by xtreak, last changed 2019-06-27 14:47 by vstinner.

Pull Requests
URL Status Linked Edit
PR 14395 merged jdemeyer, 2019-06-27 08:16
PR 14420 merged miss-islington, 2019-06-27 11:18
Messages (6)
msg320149 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python triager) Date: 2018-06-21 10:35
I was checking on https://bugs.python.org/issue30345 and https://bugs.python.org/issue33914. I looked into Travis and VSTS builds for test_gdb. Though python is built with `--with-pydebug` gdb is not installed in the builds and hence the test_gdb is skipped. Adding installation of gdb will help in making sure test_gdb is run.

# test_gdb skipped : 

* https://travis-ci.org/python/cpython/jobs/394900803#L1532

# After installation of gdb 

My build fails due to urllib errors and trying to install gdb using sudo apt-get install gdb on MacOS. The config can be fixed.

test_gdb tests : https://travis-ci.org/tirkarthi/cpython/jobs/394947895#L2501

I am willing to make a PR for Travis but I don't know how VSTS config works to test it on VSTS builds with an account.

Thanks
msg320150 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-06-21 10:37
While test_gdb is not tested on pre-commit, it's tested by buildbots on post-commit.
msg346728 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2019-06-27 11:18
New changeset 667eaffb4e5d03bf8129773f79649c3befaa5b1a by Inada Naoki (Jeroen Demeyer) in branch 'master':
bpo-33926: enable GDB tests on Travis CI (GH-14395)
https://github.com/python/cpython/commit/667eaffb4e5d03bf8129773f79649c3befaa5b1a
msg346729 - (view) Author: miss-islington (miss-islington) Date: 2019-06-27 11:47
New changeset 7e9d706fd6e2f49d2bd829890c46868105767769 by Miss Islington (bot) in branch '3.8':
bpo-33926: enable GDB tests on Travis CI (GH-14395)
https://github.com/python/cpython/commit/7e9d706fd6e2f49d2bd829890c46868105767769
msg346740 - (view) Author: Jeroen Demeyer (jdemeyer) * (Python triager) Date: 2019-06-27 14:46
Feel free to close...
msg346741 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-06-27 14:47
> Feel free to close...

What about 2.7 and 3.7 branches?
History
Date User Action Args
2019-06-27 14:47:57vstinnersetmessages: + msg346741
2019-06-27 14:46:11jdemeyersetnosy: + jdemeyer
messages: + msg346740
2019-06-27 11:47:02miss-islingtonsetnosy: + miss-islington
messages: + msg346729
2019-06-27 11:18:31miss-islingtonsetpull_requests: + pull_request14236
2019-06-27 11:18:06inada.naokisetnosy: + inada.naoki
messages: + msg346728
2019-06-27 08:16:56jdemeyersetkeywords: + patch
stage: patch review
pull_requests: + pull_request14233
2018-06-21 10:37:31vstinnersetnosy: + zach.ware
components: + Tests
2018-06-21 10:37:20vstinnersetnosy: + vstinner
messages: + msg320150
2018-06-21 10:35:39xtreakcreate