classification
Title: Install python-docs-theme even if SPHINXBUILD is defined
Type: enhancement Stage: resolved
Components: Windows Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: adelfino, miss-islington, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2018-05-30 13:20 by adelfino, last changed 2018-06-02 18:29 by adelfino. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7242 merged adelfino, 2018-05-30 13:20
PR 7248 merged miss-islington, 2018-05-30 16:08
PR 7249 merged miss-islington, 2018-05-30 16:09
Messages (4)
msg318183 - (view) Author: Andrés Delfino (adelfino) * Date: 2018-05-30 13:20
On bug 33673, I fixed python-docs-theme only getting installed if SPHINXBUILD was not defined and Sphinx was not installed, which was an improvement, but not the correct fix for python-docs-theme installation.

Now, python-docs-theme is getting installed only if SPHINXBUILD is not defined.

The attached PR fixes this, and also removes two variable assignments that are no-ops: both variables are already defined by the user as environment variables or by the script at that point.
msg318197 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-05-30 16:08
New changeset 05f1c8902c78dce66aed067444e2b973221bae2b by Steve Dower (Andrés Delfino) in branch 'master':
bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242)
https://github.com/python/cpython/commit/05f1c8902c78dce66aed067444e2b973221bae2b
msg318203 - (view) Author: miss-islington (miss-islington) Date: 2018-05-30 17:32
New changeset ea1982a475a619500c93bc3d60c6cb63a202b7ed by Miss Islington (bot) in branch '3.7':
bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242)
https://github.com/python/cpython/commit/ea1982a475a619500c93bc3d60c6cb63a202b7ed
msg318204 - (view) Author: miss-islington (miss-islington) Date: 2018-05-30 17:37
New changeset 7301dd91e8326e9b74932e81f400aaee76d3cda1 by Miss Islington (bot) in branch '3.6':
bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242)
https://github.com/python/cpython/commit/7301dd91e8326e9b74932e81f400aaee76d3cda1
History
Date User Action Args
2018-06-02 18:29:07adelfinosetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-05-30 17:37:57miss-islingtonsetmessages: + msg318204
2018-05-30 17:32:43miss-islingtonsetnosy: + miss-islington
messages: + msg318203
2018-05-30 16:09:37miss-islingtonsetpull_requests: + pull_request6875
2018-05-30 16:08:49miss-islingtonsetpull_requests: + pull_request6874
2018-05-30 16:08:28steve.dowersetmessages: + msg318197
2018-05-30 13:20:16adelfinosetkeywords: + patch
stage: patch review
pull_requests: + pull_request6868
2018-05-30 13:20:02adelfinocreate