classification
Title: unused with_c_locale_warning option in configure should be removed
Type: Stage: resolved
Components: Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: eitan.adler, inada.naoki, miss-islington, ncoghlan, vstinner
Priority: normal Keywords: patch

Created on 2018-05-25 14:11 by eitan.adler, last changed 2018-07-11 14:48 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7114 merged eitan.adler, 2018-05-25 14:16
PR 8250 merged miss-islington, 2018-07-11 11:14
Messages (9)
msg317676 - (view) Author: Eitan Adler (eitan.adler) * Date: 2018-05-25 14:11
There is an option for --with-c-locale-warning which was turned into a run-time option in eb81795d7d3a8c898fa89a376d63fc3bbfb9a081. The configuration should be cleaned up.
msg317677 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-05-25 14:15
It's related to the PEP 538.

Note: see also the PEP 540 (not directly related).
msg317680 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2018-05-25 14:43
Huh, I thought I cleaned those out when I made the compilation unconditional. I guess not :)

The actual fix looks good to me, but the autoconf regeneration looks unexpectedly noisy, so I've asked Benjamin Peterson to take a look at it.
msg317682 - (view) Author: Eitan Adler (eitan.adler) * Date: 2018-05-25 15:40
yeah, I was looking at that too. I think someone else modified related files but never ran a regen (or did so with different tooling than I).

Even on master, my regen results in changes.
msg321439 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2018-07-11 11:01
New changeset b91a3a0d61596cafb1b46c98fab65fee16a8bbbb by INADA Naoki (Eitan Adler) in branch 'master':
bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114)
https://github.com/python/cpython/commit/b91a3a0d61596cafb1b46c98fab65fee16a8bbbb
msg321440 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2018-07-11 11:04
thanks
msg321441 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-07-11 11:12
Should we backport the change to 3.7?
msg321442 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2018-07-11 11:13
Hm, it seems safe to backport.
msg321467 - (view) Author: miss-islington (miss-islington) Date: 2018-07-11 14:48
New changeset 020f5ab7170836b277ac8fef2ce7438ae0145caf by Miss Islington (bot) in branch '3.7':
bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114)
https://github.com/python/cpython/commit/020f5ab7170836b277ac8fef2ce7438ae0145caf
History
Date User Action Args
2018-07-11 14:48:45miss-islingtonsetnosy: + miss-islington
messages: + msg321467
2018-07-11 11:14:58miss-islingtonsetpull_requests: + pull_request7782
2018-07-11 11:13:33inada.naokisetversions: + Python 3.7
2018-07-11 11:13:29inada.naokisetmessages: + msg321442
2018-07-11 11:12:25vstinnersetmessages: + msg321441
versions: + Python 3.8
2018-07-11 11:04:11inada.naokisetstatus: open -> closed
resolution: fixed
messages: + msg321440

stage: patch review -> resolved
2018-07-11 11:01:29inada.naokisetnosy: + inada.naoki
messages: + msg321439
2018-05-25 15:40:13eitan.adlersetmessages: + msg317682
2018-05-25 14:43:17ncoghlansetmessages: + msg317680
2018-05-25 14:16:29eitan.adlersetkeywords: + patch
stage: patch review
pull_requests: + pull_request6752
2018-05-25 14:15:26vstinnersetnosy: + vstinner, ncoghlan
messages: + msg317677
2018-05-25 14:11:51eitan.adlercreate