classification
Title: HMAC default to MD5 marked as to be removed in 3.6
Type: behavior Stage: commit review
Components: Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, gregory.p.smith, mbussonn, miss-islington
Priority: normal Keywords: patch

Created on 2018-05-22 18:46 by mbussonn, last changed 2018-09-10 18:12 by gregory.p.smith. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7062 merged mbussonn, 2018-05-22 18:48
PR 7063 merged mbussonn, 2018-05-22 20:29
PR 7065 merged miss-islington, 2018-05-22 22:56
Messages (5)
msg317322 - (view) Author: Matthias Bussonnier (mbussonn) * Date: 2018-05-22 18:46
HMAC docs says digestmod=md5 default will be removed in 3.6, but was not. 

We should likely bumpt that to 3.8 in the documentation, and actually remove it in 3.8
msg317342 - (view) Author: Matthias Bussonnier (mbussonn) * Date: 2018-05-22 20:30
I've sent two PRs, one that updates the deprecation from PendingDeprecationWarning to DeprecationWarning that likely should get applied to 3.6, and 3.7 ?

And a PR to actually remove the default in 3.8.
msg317348 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2018-05-22 22:55
New changeset 8bb0b5b03cffa2a2e74f248ef479a9e7fbe95cf4 by Gregory P. Smith (Matthias Bussonnier) in branch 'master':
bpo-33604: Remove Pending from hmac Deprecation warning. (GH-7062)
https://github.com/python/cpython/commit/8bb0b5b03cffa2a2e74f248ef479a9e7fbe95cf4
msg317350 - (view) Author: miss-islington (miss-islington) Date: 2018-05-22 23:40
New changeset 2751dccca4098b799ea575bb35cec9959c74684a by Miss Islington (bot) in branch '3.7':
bpo-33604: Remove Pending from hmac Deprecation warning. (GH-7062)
https://github.com/python/cpython/commit/2751dccca4098b799ea575bb35cec9959c74684a
msg324942 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2018-09-10 18:10
New changeset 51a4743d19abd016f0772a57fb31df7af9220e18 by Gregory P. Smith (Matthias Bussonnier) in branch 'master':
bpo-33604: Remove deprecated HMAC default value marked for removal in 3.8 (GH-7063)
https://github.com/python/cpython/commit/51a4743d19abd016f0772a57fb31df7af9220e18
History
Date User Action Args
2018-09-10 18:12:24gregory.p.smithsetstatus: open -> closed
type: behavior
stage: patch review -> commit review
resolution: fixed
versions: - Python 3.6
2018-09-10 18:10:04gregory.p.smithsetmessages: + msg324942
2018-05-22 23:40:54miss-islingtonsetnosy: + miss-islington
messages: + msg317350
2018-05-22 22:56:44miss-islingtonsetpull_requests: + pull_request6695
2018-05-22 22:55:41gregory.p.smithsetmessages: + msg317348
2018-05-22 20:38:27serhiy.storchakasetnosy: + gregory.p.smith, christian.heimes
2018-05-22 20:30:51mbussonnsetmessages: + msg317342
2018-05-22 20:29:18mbussonnsetpull_requests: + pull_request6693
2018-05-22 18:48:50mbussonnsetkeywords: + patch
stage: patch review
pull_requests: + pull_request6692
2018-05-22 18:46:00mbussonncreate